Repository navigation
fix: Address overly aggressive parquet pruning of map cols - #27259
Open
ianthetechie wants to merge 3 commits into
Open
ianthetechie wants to merge 3 commits into
ianthetechie wants to merge 3 commits into
Conversation
github-actions
Bot
added
sqllogictest
40 of 61 tasks
Contributor
|
Not an expert on the Parquet stuff but I'll take a look and wait for people who are more familiar to approve. re backporting - that's a pretty easy process, once a PR is merged open a PR with a similar change targeting the release branch ( |
AdamGS
reviewed
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The parquet pushdown was too eager in removing map columns, causing query issues. This makes the prune more conservative. See the issue for details.
What changes are included in this PR?
This PR reduces the scope of the prune, allowing for map columns to be filtered in the WHERE clause.
What is the testing strategy for this PR?
Additional SQL logic test cases are included with a reproducible test case that fails before the changes and passes after. Existing tests were insufficient, as this regression was introduced in the DataFusion 54 series (#20854).
Are there any user-facing changes?
No user-facing changes.
I'm not sure how bug fix backports work, but it'd be nice to have this for at least DF 55 if that's not too much trouble. Otherwise I can maintain my own fork until contrib packages like geodatafusion and iceberg catch up.