Repository navigation
fix(sql): resolve dotted field access on lambda parameters (#27088) - #27232
Open
Hrushikesh-ramilla wants to merge 1 commit into
Open
Hrushikesh-ramilla wants to merge 1 commit into
Hrushikesh-ramilla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When an identifier path such as
e.rule_actionis evaluated in the body of a lambda function (whereeis a struct lambda parameter), the SQL planner producedSchema error: No field named e.rule_action.This happened because
sql_compound_identifier_to_expronly searched the input schema and outer query schemas fore.rule_action(treatingeas a table or qualifier), falling back to a relation-qualified columnColumn::new("e", "rule_action"). Unlikesql_identifier_to_expr(which checksplanner_context.lambda_parameters()first),sql_compound_identifier_to_exprnever checked for active lambda parameters.What changes are included in this PR?
datafusion/sql/src/expr/identifier.rs: updatedsql_compound_identifier_to_exprto checkplanner_context.lambda_parameters()forids[0]before attempting table-schema resolution.Expr::LambdaVariableand iterates over any remaining nested identifiers (ids[1..]), resolving each field access throughtry_plan_field_access.datafusion/sql/src/expr/mod.rs: widenedtry_plan_field_accessvisibility topub(super).datafusion/sqllogictest/test_files/array/array_transform.slt: added test coverage for dotted field access, expressions over dotted fields, and multi-level nested struct field access.What is the testing strategy for this PR?
datafusion/sqllogictest/test_files/array/array_transform.slt.datafusion-sqlpass.sqllogictests -- array_transformpasses.Are there any user-facing changes?
No.