Repository navigation
[branch-56] perf: prune oversized dictionaries before IPC spilling (backport #27015) - #27107
Merged
Merged
Conversation
Compact dictionary value tables larger than their key arrays before traversing retained physical children and writing IPC spill files. ## Which issue does this PR close? - Closes apache#27014 ## What changes are included in this PR? Compaction of dicts if there are more values than indices and tests. ## What is the testing strategy for this PR? Unit tests ## Are there any user-facing changes? No user facing changes, just an improvement to reduce I/O and total size written to disks when spilling. @alamb Co-authored-by: Amp <[email protected]> (cherry picked from commit 6a98807)
40 of 61 tasks
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## branch-56 #27107 +/- ##
=============================================
- Coverage 83.25% 83.25% -0.01%
=============================================
Files 1169 1169
Lines 474294 474311 +17
Branches 474294 474311 +17
=============================================
+ Hits 394887 394894 +7
- Misses 55485 55490 +5
- Partials 23922 23927 +5
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
xudong963
approved these changes
Nov 6, 2026
Contributor
Author
|
Thank you @brancz and @xudong963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
branch-5656.0.0(Oct/Nov 2026) #24461