Skip to content

chore: Complete the short Apache header migration - #27049

Merged
alamb merged 4 commits into
apache:mainfrom
2010YOUY01:apache-header-fix
Nov 3, 2026
Merged

alamb merged 4 commits into
apache:mainfrom
2010YOUY01:apache-header-fix

Conversation

@2010YOUY01

Copy link
Copy Markdown
Member

Important

Fork CI setup: For pull requests from a fork to main, enable workflows in your fork's Actions tab before you push.
See the fork CI setup guide.

Which issue does this PR close?

Follow-up to #26761.

Rationale for this change

From #26761:

Use the shorter Apache License 2.0 header instead. It saves tokens and screen space.

The original configuration covered only .rs, .py, .ts, and .slt. Other file types still used the long header; for example, .slt.part files were not included.

What changes are included in this PR?

Existing dev tool use hawkeye to check/generate license header: https://github.com/fast/hawkeye

  • commit 1: preparations, set up hawkeye config files
  • commit 2: ran the following command, all source license headers are auto-converted
hawkeye remove --config licenserc-legacy.toml &&
hawkeye format --config licenserc.toml &&
hawkeye check --config licenserc.toml
  • commit 3: clean up

What is the testing strategy for this PR?

Updated licenserc.toml, to ensure those previously missed file types can continue getting verified by CI (and auto-fixed by existing dev script)

ALso let Codex to double checked no unintended changes.

Are there any user-facing changes?

@github-actions github-actions Bot added documentation Improvements or additions to documentation sql SQL Planner development-process Related to development process of DataFusion logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate catalog Related to the catalog crate common Related to common crate execution Related to the execution crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate spark Changes to datafusion-spark crate labels Nov 3, 2026
@alamb
alamb added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@alamb
alamb added this pull request to the merge queue Nov 3, 2026
Merged via the queue into apache:main with commit f673e62 Nov 3, 2026
46 checks passed
@salask944-cell

Copy link
Copy Markdown

Importante

Configuración de CI de bifurcación: Para las solicitudes de extracción desde una bifurcación a , habilite los flujos de trabajo en la pestaña Accionesmain de su bifurcación antes de enviar. Consulte la guía de configuración de CI de bifurcación .****

¿Qué problema resuelve esta solicitud de extracción?

Seguimiento del número 26761 .

Justificación de este cambio

Del #26761 :

En su lugar, utilice la cabecera más corta de la Licencia Apache 2.0. Ahorra tokens y espacio en pantalla.

La configuración original cubría solo .rs, .py, .ts, y .slt. Otros tipos de archivos seguían utilizando el encabezado largo; por ejemplo, .slt.partlos archivos no se incluían.

¿Qué cambios se incluyen en esta solicitud de extracción?

Las herramientas de desarrollo existentes utilizan Hawkeye para comprobar/generar el encabezado de la licencia: https://github.com/fast/hawkeye

  • Commit 1: preparativos, configuración de los archivos de configuración de Hawkeye
  • Commit 2: se ejecutó el siguiente comando, todos los encabezados de licencia de origen se convierten automáticamente.
hawkeye remove --config licenserc-legacy.toml &&
hawkeye format --config licenserc.toml &&
hawkeye check --config licenserc.toml
  • confirmación 3: limpieza

¿Cuál es la estrategia de pruebas para esta solicitud de extracción?

Actualizado licenserc.tomlpara garantizar que los tipos de archivo que antes no se verificaban puedan seguir siendo verificados por CI (y corregidos automáticamente por el script de desarrollo existente).

Además, deje que Codex revise minuciosamente que no haya cambios no deseados.

¿Hay algún cambio que afecte a los usuarios?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate development-process Related to development process of DataFusion documentation Improvements or additions to documentation execution Related to the execution crate ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate spark Changes to datafusion-spark crate sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate v57.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants