Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review: add tracking issue in comments
  • Loading branch information
2010YOUY01 committed Nov 4, 2026
commit e205a1b0a62f910a32bba969692c1e6fab43a1d5
1 change: 1 addition & 0 deletions .github/workflows/extended.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
- name: Run fuzz tests
run: cargo xtask ci step test fuzz
# Migrate it to the above unified fuzz runner over time

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please file a ticket that explains the migration plan and has a checklist of tests to run and link it here? So we have the context in the future?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done in e205a1b

# Tracker: https://github.com/apache/datafusion/issues/27082
- name: Run unmigrated fuzzers with more iterations
run: cargo xtask ci step test fuzz-legacy
- parallel:
Expand Down
4 changes: 4 additions & 0 deletions datafusion/fuzz/tests/fuzz.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ use test_utils::fuzz::{FuzzTest, RunConfig, run};
mod suites;

/// The single registration point for project-wide fuzz campaigns.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a fuzz campaign? I am not familar with the campaign terminology

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it to run in dd6f892

///
/// Migration of the remaining fuzz tests is tracked in [#27082].
///
/// [#27082]: https://github.com/apache/datafusion/issues/27082
#[tokio::test(flavor = "multi_thread")]
async fn fuzz_tests() -> Result<()> {
let spill_pool = suites::spill_pool::SpillPoolFuzzer;
Expand Down
6 changes: 4 additions & 2 deletions test-utils/src/fuzz.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,19 @@ use std::time::Duration;
use datafusion_common::instant::Instant;
use datafusion_common::{Result, exec_err};

/// A component's fuzz experiment, run by the centralized driver.
/// A component's fuzz experiment, run by the [centralized driver].
///
/// The component prepares fixtures and checks one case; the driver handles
/// repetition, budgets, and seed reporting. Each case can be replayed alone.
///
/// See the driver in `datafusion-fuzz` for how to use it. At a high level:
/// See the [centralized driver] for how to use it. At a high level:
/// 1. Generate one dataset with `prepare_dataset()`.
/// 2. Run several cases on that dataset with `run_case()`.
/// 3. Repeat steps 1 and 2 until the time budget is reached.
///
/// (All configuration, such as the total time budget, lives in [`RunConfig`].)
///
/// [centralized driver]: https://github.com/apache/datafusion/blob/main/datafusion/fuzz/tests/fuzz.rs
#[expect(async_fn_in_trait)] // Serial execution deliberately does not require Send futures.
pub trait FuzzTest {
/// Reusable fixtures; `()` is valid when no preparation can be shared.
Expand Down