Repository navigation
test: Add a shared framework for reproducible fuzz tests #27048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+793
−310
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cbacc83
test: Add a shared framework for reproducible fuzz tests
2010YOUY01 9bec86e
Merge remote-tracking branch 'upstream/main' into fuzz-ut-framework
2010YOUY01 2b56ad9
cleanup
2010YOUY01 dd6f892
review: move spill_pool_fuzz implementation to `datafusion-fuzz` crage
2010YOUY01 e205a1b
review: add tracking issue in comments
2010YOUY01 1d48f36
Merge remote-tracking branch 'upstream/main' into fuzz-ut-framework
2010YOUY01 620c25e
Merge remote-tracking branch 'upstream/main' into fuzz-ut-framework
2010YOUY01 00019d3
fix lint
2010YOUY01 a35deb5
improve wording
2010YOUY01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
review: add tracking issue in comments
- Loading branch information
commit e205a1b0a62f910a32bba969692c1e6fab43a1d5
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,10 @@ use test_utils::fuzz::{FuzzTest, RunConfig, run}; | |
| mod suites; | ||
|
|
||
| /// The single registration point for project-wide fuzz campaigns. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is a fuzz campaign? I am not familar with the campaign terminology
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed it to |
||
| /// | ||
| /// Migration of the remaining fuzz tests is tracked in [#27082]. | ||
| /// | ||
| /// [#27082]: https://github.com/apache/datafusion/issues/27082 | ||
| #[tokio::test(flavor = "multi_thread")] | ||
| async fn fuzz_tests() -> Result<()> { | ||
| let spill_pool = suites::spill_pool::SpillPoolFuzzer; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please file a ticket that explains the migration plan and has a checklist of tests to run and link it here? So we have the context in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, done in e205a1b