Skip to content

ci: Skip macOS tests in forks - #27017

Merged
adriangb merged 1 commit into
apache:mainfrom
sdf-jkl:codex/skip-macos-fork-ci
Nov 3, 2026
Merged

adriangb merged 1 commit into
apache:mainfrom
sdf-jkl:codex/skip-macos-fork-ci

Conversation

@sdf-jkl

@sdf-jkl sdf-jkl commented Nov 2, 2026

Copy link
Copy Markdown
Member

Which issue does this PR close?

Related to #25148.

Rationale for this change

Fork CI can fail waiting for a macOS runner before any tests start, blocking the Rust (fork) check.

What changes are included in this PR?

Skip macOS tests in fork repositories, register the condition with the existing workflow validator, and document the exclusion in the contributor guide. Upstream coverage is unchanged, including the required merge-queue check, following apache/arrow-rs#11991.

Windows remains unchanged; its job is already disabled.

What is the testing strategy for this PR?

Existing workflow-validator tests, all-features Clippy, and all checks in ./dev/rust_lint.sh pass. No new tests: the existing validator checks exact job conditions against the policy table.

Are there any user-facing changes?

Contributors no longer need a macOS runner for fork CI. No runtime or API changes.

@github-actions github-actions Bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion labels Nov 2, 2026
@sdf-jkl

sdf-jkl commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

@sdf-jkl
sdf-jkl marked this pull request as ready for review November 2, 2026 19:58

@AdamGS AdamGS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ran into this issue multiple times today, thanks!

@sdf-jkl

sdf-jkl commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

@etseidl @adriangb fyi

your fork. The merge queue runs the full workflow on the merged result before
a pull request merges, so a green fork run does not replace it.

macOS tests skip fork runs to avoid runner timeouts. They remain required in the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also reduces the CI time for forks

@alamb

alamb commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thank you @sdf-jkl

@2010YOUY01 2010YOUY01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

Question: Were the failures caused by flaky GitHub Actions runners?

@adriangb

adriangb commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

yes, we saw multiple jobs timeout getting a run runner. I think they’re just aren’t that many available and public forks that don’t pay probably get the lowest priority.

@adriangb
adriangb added this pull request to the merge queue Nov 3, 2026
Merged via the queue into apache:main with commit 1635ed9 Nov 3, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion documentation Improvements or additions to documentation v56.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants