Repository navigation
perf: prune oversized dictionaries before IPC spilling - #27015
Merged
Merged
Conversation
Compact dictionary value tables larger than their key arrays before traversing retained physical children and writing IPC spill files. Exercise nested dictionaries, repeated and null keys, and uncompressed, LZ4 and Zstd spill round trips through SpillManager. Document that physical-child traversal does not guarantee complete ListView reachability pruning. Amp-Thread-ID: https://ampcode.com/threads/T-01a192af-b64d-77b7-a93b-d443169ddf9f Co-authored-by: Amp <[email protected]>
Contributor
Author
|
cc @Jefffrey |
This was referenced Nov 3, 2026
AdamGS
approved these changes
Nov 3, 2026
AdamGS
reviewed
Nov 3, 2026
| #[case(SpillCompression::Lz4Frame)] | ||
| #[case(SpillCompression::Zstd)] | ||
| #[tokio::test] | ||
| async fn test_spill_prunes_unused_nested_dictionary_values( |
Contributor
There was a problem hiding this comment.
this test makes sense to me, looking at some of the other tests here I don't think it fits in any of them.
alamb
approved these changes
Nov 4, 2026
Contributor
alamb
added a commit
that referenced
this pull request
Nov 6, 2026
…ackport #27015) (#27107) ## Which issue does this PR close? - Backport of #27015 to `branch-56` - Part of #24461 - Closes #27014 Co-authored-by: Frederic Branczyk <[email protected]> Co-authored-by: Amp <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compact dictionary value tables larger than their key arrays before traversing retained physical children and writing IPC spill files.
Which issue does this PR close?
What changes are included in this PR?
Compaction of dicts if there are more values than indices and tests.
What is the testing strategy for this PR?
Unit tests
Are there any user-facing changes?
No user facing changes, just an improvement to reduce I/O and total size written to disks when spilling.
@alamb