Repository navigation
Conversation
… CASE Document the current behavior: field metadata (including Arrow extension types) is dropped by coalesce, nvl, ifnull, nvl2 and CASE expressions. The intended results are recorded in comments next to each query. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
CASEexpressions drop field metadata, silently stripping Arrow extension types and breaking metadata-aware UDFs #24860Rationale for this change
While reviewing #24865 I found that
coalesce,nvl,ifnullandnvl2are rewritten toCASEduring simplification, andCASEdrops field metadataThis wasn't caught because there was no end user API coverage
These tests document the current behavior end to end so a fix can be verified against them.
What changes are included in this PR?
Add New cases in
metadata.sltforcoalesce,nvl,ifnull,nvl2andCASEthat document existing behavior with some comments explaining what the expected results areWhat is the testing strategy for this PR?
Tests only.
Are there any user-facing changes?
No.