Repository navigation
Ordering tests on dictionary types - #26834
Merged
alamb merged 2 commits intoOct 27, 2026
Merged
Conversation
alamb
enabled auto-merge
October 27, 2026 21:15
Contributor
|
(great to see you again!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Adds tests for #4649 to ensure no regressions
Rationale for this change
What changes are included in this PR?
New slt tests on a dictionary column that cover all permutations of ASC/DESC and nulls FIRST/LAST
What is the testing strategy for this PR?
New tests for a previously reported bug that has already been fixed but we didnt have coverage to ensure we dont regress.
Are there any user-facing changes?
No