Repository navigation
chore: Use short Apache license header - #26761
Merged
Merged
Conversation
Contributor
|
More than happy to approve this, but might be worth leaving open for a bit to make sure no one with more context/APACHE experience knows some reason to block this. |
AdamGS
approved these changes
Oct 26, 2026
Contributor
|
FWIW - the PR is so big that it seems to have broken something in the "review" tab and I had to use the CLI 🤣 |
xudong963
approved these changes
Oct 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
Member
Author
It's been open for two days with no objections so far. Let's go ahead and merge it. @AdamGS @xudong963 Thank you for the review. |
alamb
pushed a commit
to cblp/datafusion
that referenced
this pull request
Nov 3, 2026
> [!IMPORTANT] > > **Fork CI setup:** For pull requests from a fork to `main`, enable workflows in your fork's **Actions** tab before you push. > See the [fork CI setup guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks). ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> Follow-up to apache#26761. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> From apache#26761: > Use the shorter Apache License 2.0 header instead. It saves tokens and screen space. The original configuration covered only `.rs`, `.py`, `.ts`, and `.slt`. Other file types still used the long header; for example, `.slt.part` files were not included. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> Existing dev tool use hawkeye to check/generate license header: https://github.com/fast/hawkeye - commit 1: preparations, set up hawkeye config files - commit 2: ran the following command, all source license headers are auto-converted ``` hawkeye remove --config licenserc-legacy.toml && hawkeye format --config licenserc.toml && hawkeye check --config licenserc.toml ``` - commit 3: clean up ## What is the testing strategy for this PR? Updated `licenserc.toml`, to ensure those previously missed file types can continue getting verified by CI (and auto-fixed by existing dev script) ALso let Codex to double checked no unintended changes. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'. If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it. You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised. --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. -->
bvolpato
pushed a commit
to bvolpato/datafusion
that referenced
this pull request
Nov 6, 2026
…ression (apache#27145) ## Which issue does this PR close? - Partly closes apache#27108. - Reverts apache#25790. ## Rationale for this change On TPC-H Q18, DataFusion 56 takes about 233 s and 22 GB of peak memory on an M3 Max, compared with about 7 s and 4 GB on 55.1.0. On x86_64 the process runs out of memory (apache#27108). @devanbenz traced the regression to apache#25790: the new Decimal filter selectivity estimate changes the join order of the plan. As agreed in apache#24461 (comment), this PR reverts apache#25790 before the 56 release. apache#27146 tracks the work to re-land the change. ## What changes are included in this PR? This reverts commit 6145a09. The only conflict was `filter_statistics_decimal.slt`, which apache#25790 added and apache#26761 later edited. This PR deletes it. ## What is the testing strategy for this PR? The existing tests, which pass locally. ## Are there any user-facing changes? Filters on Decimal columns use the selectivity estimate from 55.x again. ---- Disclaimer: I used AI to assist in the code generation, I have manually reviewed the output and it matches my intention and understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Use the shorter Apache License 2.0 header instead. It saves tokens and screen space.
The shorter 3-lines form is explicitly allowed from ASF guide: https://www.apache.org/legal/src-headers.html?utm_source=chatgpt.com#is-an-spdx-form-of-the-source-header-acceptable
Before:
datafusion/datafusion/common/src/alias.rs
Lines 1 to 16 in 350ca76
After: https://www.apache.org/legal/src-headers.html?utm_source=chatgpt.com#is-an-spdx-form-of-the-source-header-acceptable
What changes are included in this PR?
Existing dev tool use
hawkeyeto check/generate license header: https://github.com/fast/hawkeyecommit 1: preparations, set up
hawkeyeconfig filescommit 2: ran the following command, all source license headers are auto-converted
commit 3: clean up
What is the testing strategy for this PR?
I've let codex double checked no missing files, and no unintended changes.
Also CI validates new header:
datafusion/.github/workflows/dev.yml
Line 39 in 350ca76
Are there any user-facing changes?