Repository navigation
test: add NULL values to Fuzz window - #26386
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26386 +/- ##
==========================================
- Coverage 82.89% 82.89% -0.01%
==========================================
Files 1154 1154
Lines 458022 458022
Branches 458022 458022
==========================================
- Hits 379683 379675 -8
- Misses 55303 55307 +4
- Partials 23036 23040 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jayzhan211
approved these changes
Oct 18, 2026
jayzhan211
left a comment
jayzhan211
left a comment
Contributor
There was a problem hiding this comment.
One minor issue, could be merge after #25860
The test data now has NULL values. The NULL rate changes between 0, 0.01, 0.1 and 0.5.
Each of the columns 'a', 'b' and 'c' gets a random sort direction and a random NULL position.
Nagato-Yuzuru
force-pushed
the
fuzz-window-nulls
branch
from
October 18, 2026 17:42
38e3d8a to
20db6e1
Compare
Contributor
|
Thank you @Nagato-Yuzuru and @jayzhan211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #24243.
This PR adds NULL values to the window fuzz test, as planned.
Rationale for this change
The window fuzz test had two gaps:
ASC NULLS FIRST.With these gaps closed, the test finds wrong results on
main. All of themcome from one known error: #25859.
What changes are included in this PR?
and 0.5.
Note: a seed now gives different data than before this PR.
What is the testing strategy for this PR?
cargo test --profile ci -p datafusion --features extended_tests --test fuzz -- window_fuzzOn
main, the test fails. For example:All failures have a
RANGEframe that ends inN PRECEDING, and NULL values inthe data. They occur with all four sort orders (ASC/DESC, NULLS FIRST/LAST).
Additional notes
#25860 fixes #25859. With #25860, this test passes. This PR must merge after
#25860. Or, if the author of #25860 agrees, these commits can go into #25860.
Are there any user-facing changes?
No