Repository navigation
docs: explain timestamp timezone comparisons - #26294
Closed
Harshil-1603 wants to merge 1 commit into
Closed
Harshil-1603 wants to merge 1 commit into
Harshil-1603 wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
documentation
alamb
added
the
Prolific Author
Contributor
|
Thanks for the contribution! I am closing this under DataFusion's AI Dump policy. This has the hallmarks of AI code that was not reviewed by the author: a docs-only change whose testing section discusses clippy, opened the same day as a sibling PR that admits its checks did not pass. If you would like to continue, please open a focused PR in your own words that you have reviewed and understand, and we are happy to help with review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10344.
Rationale for this change
The type reference describes timestamp types but does not explain how timestamps with different or missing timezone metadata compare. In particular, a naive timestamp is interpreted in the other operand's timezone, which can surprise users expecting UTC.
What changes are included in this PR?
Document Arrow's aware and naive timestamp representation, the comparison coercion rules, two runnable SQL examples, and the distinction from timestamp arithmetic. This is documentation only and does not change timestamp behavior.
What is the testing strategy for this PR?
trueresult.cargo fmt --all -- --check, the documentation Prettier script, andgit diff --checkpassed.mutable_key_typeerrors indatafusion/optimizer/src/push_down_filter.rs(Clippy fails with all features enabled #26181). No runtime code is changed.Are there any user-facing changes?
The SQL type reference now explains timezone semantics and comparisons. This contribution was prepared with AI assistance and checked against the current coercion implementation and actual query results.
@alamb, could you please enable CI for this documentation contribution?