Repository navigation
ci: add slt-only test coverage - #26219
Conversation
github-actions
Bot
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## main #26219 +/- ##
==========================================
- Coverage 82.80% 82.80% -0.01%
==========================================
Files 1149 1149
Lines 452234 454165 +1931
Branches 452234 454165 +1931
==========================================
+ Hits 374484 376049 +1565
- Misses 54952 55264 +312
- Partials 22798 22852 +54
... and 155 files with indirect coverage changes 🚀 New features to boost your workflow:
|
eabaec5 to
37380f7
Compare
There was a problem hiding this comment.
Thanks for adding separate SQLLogicTest coverage reporting. This addresses the need to identify gaps in end-to-end SQL test coverage that aggregate coverage can conceal. The implementation is focused, and the additional complexity is justified by the independent measurement it provides.
I see no blocking concerns. Approving.
|
|
||
| # Upload code coverage report, GitHub bot will comment with the code coverage report. | ||
| # | ||
| # It has two reports: |
There was a problem hiding this comment.
Should we move all the code coverage jobs to this workflow (rather than some in rust?)
There was a problem hiding this comment.
The issue is that now the default test run and coverage generation are combined to save CI time.
Maybe it's better to move this job to rust.yml, and combine it with default coverage job to save some compile time 🤔 will give it a try later.
# Conflicts: # xtask/src/ci_steps.rs
Which issue does this PR close?
Rationale for this change
Add test coverage report for individual sqllogictest runs. For motivation, see PR diff file
docs/source/contributor-guide/testing.mdDemo
See the bot reply in the current PR,
It means Datafusion now reaches 66% test line coverage from slt alone -- you can click into codecov website to further browse each file's coverage from slt alone, by selecting the flag.
What changes are included in this PR?
What is the testing strategy for this PR?
Verify if the codecov bot reply in this PR works
Are there any user-facing changes?
no