Skip to content

chore(optimizer): remove deprecated supports_rewrite - #26180

Merged
2010YOUY01 merged 1 commit into
apache:mainfrom
haohuaijin:remove-supports-rewrite
Oct 12, 2026
Merged

chore(optimizer): remove deprecated supports_rewrite#26180
2010YOUY01 merged 1 commit into
apache:mainfrom
haohuaijin:remove-supports-rewrite

Conversation

@haohuaijin

@haohuaijin haohuaijin commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

no related issue

Rationale for this change

OptimizerRule::supports_rewrite has been deprecated since DataFusion 47.0.0 and is no longer called by the optimizer. Its deprecation exceeds both the six-major-version and six-month retention periods in the API health policy.

What changes are included in this PR?

remove OptimizerRule::supports_rewrite

What is the testing strategy for this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added optimizer Optimizer rules core Core DataFusion crate labels Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details 
     Cloning apache/main
    Building datafusion v55.1.0 (current)
       Built [  58.056s] (current)
     Parsing datafusion v55.1.0 (current)
      Parsed [   0.032s] (current)
    Building datafusion v55.1.0 (baseline)
       Built [  55.158s] (baseline)
     Parsing datafusion v55.1.0 (baseline)
      Parsed [   0.032s] (baseline)
    Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.645s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 115.682s] datafusion
    Building datafusion-optimizer v55.1.0 (current)
       Built [  24.942s] (current)
     Parsing datafusion-optimizer v55.1.0 (current)
      Parsed [   0.032s] (current)
    Building datafusion-optimizer v55.1.0 (baseline)
       Built [  24.991s] (baseline)
     Parsing datafusion-optimizer v55.1.0 (baseline)
      Parsed [   0.034s] (baseline)
    Checking datafusion-optimizer v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.159s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip

--- failure trait_method_missing: pub trait method removed or renamed ---

Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron

Failed in:
  method supports_rewrite of trait OptimizerRule, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/853df399cc9705a292ac6e0485289910ef50865b/datafusion/optimizer/src/optimizer.rs:98
  method supports_rewrite of trait OptimizerRule, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/853df399cc9705a292ac6e0485289910ef50865b/datafusion/optimizer/src/optimizer.rs:98

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  52.599s] datafusion-optimizer

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Oct 10, 2026
@haohuaijin haohuaijin mentioned this pull request Oct 10, 2026
Closed
@codecov-commenter

codecov-commenter commented Oct 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.79%. Comparing base (4e6e564) to head (43ccf5b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #26180      +/-   ##
==========================================
+ Coverage   82.77%   82.79%   +0.01%     
==========================================
  Files        1148     1148              
  Lines      451075   450994      -81     
  Branches   451075   450994      -81     
==========================================
- Hits       373397   373395       -2     
+ Misses      54930    54850      -80     
- Partials    22748    22749       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nuno-faria
nuno-faria approved these changes Oct 10, 2026
View reviewed changes

@nuno-faria nuno-faria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haohuaijin.

@2010YOUY01
2010YOUY01 added this pull request to the merge queue Oct 12, 2026
Merged via the queue into apache:main with commit e6a11e5 Oct 12, 2026
44 checks passed
@haohuaijin
haohuaijin deleted the remove-supports-rewrite branch October 12, 2026 08:27
@haohuaijin

haohuaijin commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @nuno-faria @2010YOUY01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuno-faria nuno-faria nuno-faria approved these changes

Assignees

No one assigned

Labels

auto detected api change Auto detected API change core Core DataFusion crate optimizer Optimizer rules v56.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haohuaijin @codecov-commenter @nuno-faria @2010YOUY01