Repository navigation
Preserve list element metadata when rebuilding scalar values - #26092
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26092 +/- ##
==========================================
- Coverage 82.78% 82.77% -0.01%
==========================================
Files 1148 1148
Lines 451075 451090 +15
Branches 451075 451090 +15
==========================================
+ Hits 373400 373401 +1
- Misses 54927 54935 +8
- Partials 22748 22754 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
getChan
approved these changes
Oct 11, 2026
getChan
left a comment
getChan
left a comment
Contributor
There was a problem hiding this comment.
This is a sound fix that preserves metadata previously lost during LIST scalar conversion. Metadata::clone() is inexpensive because it shares the underlying Arc, and with_metadata() moves the metadata into the field without any additional copying. LGTM.
Jefffrey
approved these changes
Oct 14, 2026
Contributor
|
thanks @osipovartem & @getChan |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScalarValue::cast_toreconstructs LIST values throughSingleRowListArrayBuilder::with_field. That builder copied the child field name and nullability but dropped its metadata. Casting a LIST to a target field containing nested metadata (for example an IcebergPARQUET:field_id) therefore produced a scalar with a different type from the requested target, and subsequent batch expansion could fail schema validation.Copy the field metadata as well. This only runs when constructing a scalar LIST; columnar cast and batch fast paths are unchanged.
Validation
cargo +1.95.0 test --offline -p datafusion-common --lib: 624 passed.cargo +1.95.0 fmt --all --check: passed.