Repository navigation
fix: preserve DISTINCT semantics in lateral decorrelation - #26060
Closed
mikamikasuki wants to merge 2 commits into
Closed
mikamikasuki wants to merge 2 commits into
mikamikasuki wants to merge 2 commits into
Conversation
github-actions
Bot
added
optimizer
alamb
added
the
Prolific Author
Contributor
|
Thanks for the contribution! I am closing this under DataFusion's AI Dump policy. This has the hallmarks of AI code that was not reviewed by the author: one of eight PRs opened in a single day, adding a 170-line special-case rewrite for one plan shape with many silent fallbacks, and a description listing local checks run. If you would like to continue, please open a focused PR in your own words that you have reviewed and understand, and we are happy to help with review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The query in #25808 returns the same
(outer key, distinct value)row more than once. Moving a correlated filter aboveDISTINCTmakes rows that differ only in the filtered inner column appear distinct, even though that column is not part of the visible result.What changes are included in this PR?
For the supported INNER LATERAL shape, apply the correlated filter before the DISTINCT aggregation. A unique row number on each outer input row preserves bag semantics when the outer input itself contains duplicates. Unsupported plan shapes continue through the existing decorrelation path.
What is the testing strategy for this PR?
Added
lateral_join.sltregression cases for the issue query, duplicate outer rows, and explicitJOIN LATERAL ... ON TRUE. The issue case fails on the base commit and passes with this change. The optimizer unit and integration tests, focused lateral join sqllogictests, the extended workspace test suite, strict optimizer clippy, formatting, andgit diff --checkpassed.Are there any user-facing changes?
The affected LATERAL DISTINCT query now returns the expected distinct rows.