Repository navigation
fix: preserve timezone casts in timestamp comparisons - #26049
Closed
mikamikasuki wants to merge 2 commits into
Closed
mikamikasuki wants to merge 2 commits into
mikamikasuki wants to merge 2 commits into
Conversation
github-actions
Bot
added
physical-expr
alamb
added
the
Prolific Author
mikamikasuki
marked this pull request as ready for review
October 24, 2026 22:50
Contributor
|
Merge conflicts |
alamb
marked this pull request as draft
October 29, 2026 17:38
Contributor
|
Sorry I don't think we have time to handle so many AI generated pull requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When a timestamp without a time zone is cast to a timestamp with a time zone, comparison simplification can move the cast from a column to a literal and change the represented instant. This can make a literal comparison return no rows even when an equivalent column comparison matches.
What changes are included in this PR?
Preserve naive-to-zoned timestamp casts on column expressions during logical and physical comparison simplification.
What is the testing strategy for this PR?
Updated
timestamps_timezone.sltto assert the matching row and retained cast in the plan, and added physical-expression regression coverage.Validated with
cargo fmt --all -- --check,cargo clippy --all-targets --all-features -- -D warnings, and the full extended workspace test suite.Are there any user-facing changes?
Timestamp comparisons involving naive-to-zoned column casts return the matching rows for non-UTC time zones.