Repository navigation
Keep ClickBench SQL in sync across runners - #25773
Merged
Merged
Conversation
- Added benchmarks/tests/clickbench_parity.rs with standard, extended .benchmark ↔ SLT membership and legacy .sql ID/SQL checks. - Included empty named exception list and comment/whitespace normalization. - Removed Q6 redundant URL cast. - Added extended Q15/Q16 benchmarks and SLT coverage; generated outputs (0). - Updated ClickBench SLT maintenance pointers.
- Preserves single/double/dollar quoted whitespace/newlines. - Handles E'...' escapes. - Added regressions.
…ries - read_slt_queries now includes first-file query. - Added interleaved + multiline SLT regression.
- Quote-aware SLT detection, ignoring fake query inside SQL literals - Skip expected-output blocks before next directive - Added two new regressions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25773 +/- ##
==========================================
- Coverage 82.84% 82.84% -0.01%
==========================================
Files 1151 1151
Lines 455510 455510
Branches 455510 455510
==========================================
- Hits 377362 377351 -11
- Misses 55236 55244 +8
- Partials 22912 22915 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kosiew
marked this pull request as ready for review
September 26, 2026 10:09
Contributor
|
I don't know if we need the parity test to be honest - at least for queries vs sql_benchmarks/... At some point this fall I plan on either removing the queries in benchmark/queries or pointing the sql benchmarks at the query files. More likely the latter though I do think there is a few queries where that may be problematic. Otherwise lgtm. |
adriangb
approved these changes
Oct 14, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The extended Q6 benchmark uses different SQL from the other ClickBench runners, while Q15 and Q16 are absent from the SQL-benchmark suite and SQL logic test. These copies can drift again when a query is edited in only one place.
What changes are included in this PR?
Are these changes tested?
The patch adds
clickbench_parity.rsand six unit tests covering SQL logic test parsing and SQL normalization. It also adds Q15/Q16 SQL logic test entries with expected value0.The diff does not show test execution, generation of those expected values, or the requested Q6 comparisons in single and partitioned configurations.
Are there any user-facing changes?
The extended Q6 SQL benchmark now runs without the URL cast. Q15 and Q16 are added to the extended SQL-benchmark suite. The diff does not establish whether removing the cast changes Q6 results. No public API change is shown.
LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.