Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review: update deprecation note and point to replacement API
  • Loading branch information
2010YOUY01 committed Oct 1, 2026
commit 0880e988132bc32ce227f627b6c9c4c55340c957
4 changes: 2 additions & 2 deletions datafusion/physical-plan/src/aggregates/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,7 @@ impl AggregateExec {
/// aggregation when the request is unsupported.
#[deprecated(
since = "56.0.0",
note = "This API is intended for internal use only and was inadvertently made public. Do not use this API."
note = "The replacement APIs are [`try_optimize_topk`](Self::try_optimize_topk) and [`try_optimize_distinct_soft_limit`](Self::try_optimize_distinct_soft_limit). They still require specific plan-shape invariants to be used correctly, so they remain internal for now. If you have a use case that requires these APIs to be public, please open an issue in DataFusion."
)]
pub fn with_new_limit_options(&self, limit_options: Option<LimitOptions>) -> Self {
let mut new = self.clone().without_optimization();
Expand Down Expand Up @@ -1383,7 +1383,7 @@ impl AggregateExec {
/// Set a legacy limit hint. Unsupported requests leave ordinary aggregation.
#[deprecated(
since = "56.0.0",
note = "This API is intended for internal use only and was inadvertently made public. Do not use this API."
note = "The replacement APIs are [`try_optimize_topk`](Self::try_optimize_topk) and [`try_optimize_distinct_soft_limit`](Self::try_optimize_distinct_soft_limit). They still require specific plan-shape invariants to be used correctly, so they remain internal for now. If you have a use case that requires these APIs to be public, please open an issue in DataFusion."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

)]
pub fn with_limit_options(self, limit_options: Option<LimitOptions>) -> Self {
let ordinary = self.without_optimization();
Expand Down
Loading