Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test case
  • Loading branch information
haohuaijin committed Sep 14, 2026
commit 6d0e2b186b0b9bb0b65b2dc2c24abb8dbd3803dd
119 changes: 119 additions & 0 deletions datafusion/sqllogictest/test_files/dynamic_filter_pushdown_config.slt
Original file line number Diff line number Diff line change
Expand Up @@ -1057,3 +1057,122 @@ DROP TABLE issue_25244_b;

statement ok
RESET datafusion.optimizer.join_reordering;

# Regression for https://github.com/apache/datafusion/issues/25296.
# Both joins expose columns named amount. The TopK filter on p.amount must
# not be remapped by name to o.amount in the lower join's output. Orders is
# larger than payments so it streams on the probe side. One row per batch
# and row group lets TopK update its filter before later orders are read.
# Name-based remapping prunes those orders and incorrectly returns (100, 30).
statement ok
SET datafusion.execution.target_partitions = 1;

statement ok
SET datafusion.execution.batch_size = 1;

statement ok
CREATE TABLE issue_25296_orders_src(id INT, amount INT) AS VALUES
(1, 100), (2, 200), (3, 300), (4, 400), (5, 500), (6, 600);

statement ok
CREATE TABLE issue_25296_payments_src(id INT, amount INT) AS VALUES
(1, 30), (2, 20), (3, 10);

statement ok
CREATE TABLE issue_25296_customers_src(id INT) AS VALUES (1), (2), (3);

query I
COPY issue_25296_orders_src TO 'test_files/scratch/dynamic_filter_pushdown_config/issue_25296_orders.parquet'
STORED AS PARQUET OPTIONS ('format.max_row_group_size' '1');
----
6

query I
COPY issue_25296_payments_src TO 'test_files/scratch/dynamic_filter_pushdown_config/issue_25296_payments.parquet'
STORED AS PARQUET;
----
3

query I
COPY issue_25296_customers_src TO 'test_files/scratch/dynamic_filter_pushdown_config/issue_25296_customers.parquet'
STORED AS PARQUET;
----
3

statement ok
CREATE EXTERNAL TABLE issue_25296_orders(id INT, amount INT) STORED AS PARQUET
LOCATION 'test_files/scratch/dynamic_filter_pushdown_config/issue_25296_orders.parquet';

statement ok
CREATE EXTERNAL TABLE issue_25296_payments(id INT, amount INT) STORED AS PARQUET
LOCATION 'test_files/scratch/dynamic_filter_pushdown_config/issue_25296_payments.parquet';

statement ok
CREATE EXTERNAL TABLE issue_25296_customers(id INT) STORED AS PARQUET
LOCATION 'test_files/scratch/dynamic_filter_pushdown_config/issue_25296_customers.parquet';

# Establish the expected result without TopK dynamic filtering.
statement ok
SET datafusion.optimizer.enable_topk_dynamic_filter_pushdown = false;

query II
SELECT o.amount, p.amount
FROM issue_25296_orders o
JOIN issue_25296_payments p ON o.id = p.id
JOIN issue_25296_customers c ON p.id = c.id
ORDER BY p.amount LIMIT 1;
----
300 10

# Enabling TopK dynamic filtering must preserve the result.
statement ok
SET datafusion.optimizer.enable_topk_dynamic_filter_pushdown = true;

query II
SELECT o.amount, p.amount
FROM issue_25296_orders o
JOIN issue_25296_payments p ON o.id = p.id
JOIN issue_25296_customers c ON p.id = c.id
ORDER BY p.amount LIMIT 1;
----
300 10

# Also exercise Parquet row filtering in addition to row-group pruning.
statement ok
SET datafusion.execution.parquet.pushdown_filters = true;

query II
SELECT o.amount, p.amount
FROM issue_25296_orders o
JOIN issue_25296_payments p ON o.id = p.id
JOIN issue_25296_customers c ON p.id = c.id
ORDER BY p.amount LIMIT 1;
----
300 10

statement ok
DROP TABLE issue_25296_orders;

statement ok
DROP TABLE issue_25296_payments;

statement ok
DROP TABLE issue_25296_customers;

statement ok
DROP TABLE issue_25296_orders_src;

statement ok
DROP TABLE issue_25296_payments_src;

statement ok
DROP TABLE issue_25296_customers_src;

statement ok
RESET datafusion.execution.batch_size;

statement ok
SET datafusion.execution.target_partitions = 4;

statement ok
RESET datafusion.execution.parquet.pushdown_filters;
Loading