Repository navigation
refactor: exhaustively destructure dynamic filter and scalar subquery proto hooks - #25178
Merged
kumarUjjawal merged 1 commit intoSep 16, 2026
Conversation
github-actions
Bot
added
physical-expr
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25178 +/- ##
=======================================
Coverage 81.90% 81.90%
=======================================
Files 1132 1132
Lines 420940 420958 +18
Branches 420940 420958 +18
=======================================
+ Hits 344786 344805 +19
+ Misses 55771 55770 -1
Partials 20383 20383 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
approved these changes
Sep 16, 2026
kumarUjjawal
left a comment
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @peterxcli for working on this.
LGTM!
Omega359
pushed a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Oct 11, 2026
… proto hooks (apache#25178) ## Which issue does this PR close? Closes apache#24618. ## Rationale for this change This change makes the compiler catch fields that serialization does not handle. When a field is added to a dynamic filter, scalar subquery expression, or its protobuf payload, the corresponding hook must account for it. This helps prevent new fields from being silently dropped when expressions are encoded and decoded. ## What changes are included in this PR? All four encoding and decoding hooks for `DynamicFilterPhysicalExpr` and `ScalarSubqueryExpr` explicitly list every field without a rest pattern. Dynamic filter encoding also destructures the snapshot of its shared inner state, and decoding handles the expression ID carried by the enclosing message. Comments explain why caches, watch channels, cached type and nullability checks, and subquery results are omitted, including how they are rebuilt or supplied. The PR also replaces one use of unstable `std::assert_matches` in an existing execution test with `assert!(…is_ok())`, allowing the required checks to run on the pinned stable compiler. ## What is the testing strategy for this PR? Existing tests cover filter identity, shared updates, remapped children, subquery metadata, nested result scopes, and execution after serialization. The physical expression suite passed 1,739 tests with 2 ignored, and all 13 relevant protobuf integration tests passed. The full extended workspace run passed 11,591 Rust tests, with 8 ignored, and completed all 516 SQLLogicTest files. Formatting, Clippy with all targets and features and warnings denied, and the complete `./dev/rust_lint.sh` suite also passed. ## Are there any user-facing changes? No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #24618.
Rationale for this change
This change makes the compiler catch fields that serialization does not handle. When a field is added to a dynamic filter, scalar subquery expression, or its protobuf payload, the corresponding hook must account for it. This helps prevent new fields from being silently dropped when expressions are encoded and decoded.
What changes are included in this PR?
All four encoding and decoding hooks for
DynamicFilterPhysicalExprandScalarSubqueryExprexplicitly list every field without a rest pattern. Dynamic filter encoding also destructures the snapshot of its shared inner state, and decoding handles the expression ID carried by the enclosing message.Comments explain why caches, watch channels, cached type and nullability checks, and subquery results are omitted, including how they are rebuilt or supplied.
The PR also replaces one use of unstable
std::assert_matchesin an existing execution test withassert!(…is_ok()), allowing the required checks to run on the pinned stable compiler.What is the testing strategy for this PR?
Existing tests cover filter identity, shared updates, remapped children, subquery metadata, nested result scopes, and execution after serialization. The physical expression suite passed 1,739 tests with 2 ignored, and all 13 relevant protobuf integration tests passed.
The full extended workspace run passed 11,591 Rust tests, with 8 ignored, and completed all 516 SQLLogicTest files. Formatting, Clippy with all targets and features and warnings denied, and the complete
./dev/rust_lint.shsuite also passed.Are there any user-facing changes?
No.