Add SQL planner support for grouping() aggregate expressions#2486
Add SQL planner support for grouping() aggregate expressions#2486andygrove merged 4 commits intoapache:masterfrom
grouping() aggregate expressions#2486Conversation
andygrove
changed the title
grouping() aggregate expressionsgrouping() aggregate expressions
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
TIL "GROUPING" 🤯
https://www.postgresql.org/docs/9.5/functions-aggregate.html (Table 9-53. Grouping Operations) and https://docs.microsoft.com/en-us/sql/t-sql/functions/grouping-transact-sql?view=sql-server-ver15
| } | ||
|
|
||
| fn create_accumulator(&self) -> Result<Box<dyn Accumulator>> { | ||
| Err(DataFusionError::NotImplemented( |
There was a problem hiding this comment.
👍
I see -- I was going to suggest adding a test to sql_integ but it isn't ready yet 👍
I hadn't seen this before either, but it is used in the TPC-DS benchmarks. |
2 participants
Which issue does this PR close?
Closes #2477
Rationale for this change
Add support for planning SQL queries containing
grouping()aggregate expressionsWhat changes are included in this PR?
Add support for planning SQL queries containing
grouping()aggregate expressionsAre there any user-facing changes?
No