Skip to content

Comments

Adds unit test cases of mathematical expressions working with null literal#2478

Merged
alamb merged 1 commit intoapache:masterfrom
WinkerDu:master-sqrt-null
May 8, 2022
Merged

Adds unit test cases of mathematical expressions working with null literal#2478
alamb merged 1 commit intoapache:masterfrom
WinkerDu:master-sqrt-null

Conversation

@WinkerDu
Copy link
Contributor

@WinkerDu WinkerDu commented May 7, 2022

Which issue does this PR close?

Closes #1188 .

Rationale for this change

Since #2364 is merged, mathematical function calls with null literal work well. This pr is just adding unit test cases of mathematical expressions working with null literal.

What changes are included in this PR?

  • Adds unit test cases of mathematical expressions working with null
  • All mathematical expressions is listed in math_expressions.rs

Are there any user-facing changes?

No.

@WinkerDu
Copy link
Contributor Author

WinkerDu commented May 7, 2022

cc @andygrove @alamb
Please have a review, thank you

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you @WinkerDu

@alamb alamb merged commit f943b6a into apache:master May 8, 2022
@WinkerDu
Copy link
Contributor Author

WinkerDu commented May 8, 2022

Thank you @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function calls with NULL literals do not work

2 participants