Repository navigation
main branch test fix: adjust dynamic filter assertion for hash collisions handling - #24729
Merged
alamb merged 1 commit intoAug 27, 2026
Merged
Conversation
Contributor
Author
|
If the CI is green, we could merge this, if not, anyone who have time could go ahead to fix this, thanks a lot |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24729 +/- ##
==========================================
- Coverage 81.45% 81.44% -0.01%
==========================================
Files 1120 1120
Lines 401793 401795 +2
Branches 401793 401795 +2
==========================================
- Hits 327262 327256 -6
- Misses 55356 55362 +6
- Partials 19175 19177 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Merging to get CI clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#24587 is auto merged with failed test, this fix the test. The issue is something from
feature = "force_hash_collisions"Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?