Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review: return reference
  • Loading branch information
2010YOUY01 committed Aug 2, 2026
commit 664b84a4ce46ee91fe67ddca0baf232e43c49121
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,8 @@ impl<AggrMode> AggregateHashTable<AggrMode> {
}
}

pub(in crate::aggregates) fn group_by_metrics(&self) -> GroupByMetrics {
self.group_by_metrics.clone()
pub(in crate::aggregates) fn group_by_metrics(&self) -> &GroupByMetrics {
&self.group_by_metrics
}

/// Returns the number of distinct groups accumulated so far.
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/aggregates/single_stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ impl SingleHashAggregateStream {
let timer = elapsed_compute.timer();
let replay = match spill_context.spill_table(&mut hash_table) {
Ok(()) => {
let group_by_metrics = hash_table.group_by_metrics();
let group_by_metrics = hash_table.group_by_metrics().clone();
drop(hash_table);
match self.reservation.try_resize(0) {
Ok(()) => (*spill_context).into_replay_stream(
Expand Down