Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
review: return error on memory update failure
  • Loading branch information
2010YOUY01 committed Jul 11, 2026
commit 1af238d615ba20fa5eeb5de1fc466ced41ea5777
12 changes: 9 additions & 3 deletions datafusion/physical-plan/src/aggregates/single_stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ use futures::stream::{Stream, StreamExt};

use super::AggregateExec;
use super::aggregate_hash_table::{AggregateHashTable, SingleMarker};
use crate::metrics::{BaselineMetrics, RecordOutput, SpillMetrics};
use crate::metrics::{BaselineMetrics, RecordOutput};
use crate::stream::EmptyRecordBatchStream;
use crate::{InputOrderMode, RecordBatchStream, SendableRecordBatchStream};

Expand Down Expand Up @@ -269,9 +269,15 @@ impl SingleHashAggregateStream {

match result {
Ok(Some(batch)) => {
let _ = self
if let Err(e) = self
.reservation
.try_resize(original_state.hash_table().memory_size());
.try_resize(original_state.hash_table().memory_size())
{
return ControlFlow::Break((
Poll::Ready(Some(Err(e))),
original_state,
));
}
debug_assert!(batch.num_rows() > 0);
let next_state = if original_state.hash_table().is_done() {
original_state.into_done()
Expand Down
Loading