Repository navigation
chore(catalog-listing): remove deprecated split_files free fn (Closes #23080) - #23152
Merged
alamb merged 1 commit intoJun 24, 2026
Conversation
…pache#23080) Removes the free function `split_files` from `datafusion_catalog_listing::helpers`, deprecated since 47.0.0 in favor of the `FileGroup::split_files` method on `datafusion-catalog/datasource::file_groups::FileGroup`. Verified across the workspace: - 0 non-test call sites for the free function - In-tree tests at helpers.rs::test_split_files already exercise the `FileGroup::split_files` method, not the removed fn - Test `datafusion_catalog_listing::test_split_files` still passes Refs apache#23080 (partial; following the deprecation-removal series apache#23129, apache#23131, apache#23132, apache#23134, apache#23135, apache#23142, apache#23143, apache#23144, apache#23145). Signed-off-by: Dodothereal <[email protected]>
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
alamb
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23080 (partial)
Summary
Removes
datafusion_catalog_listing::helpers::split_files, deprecated since 47.0.0 in favor of theFileGroup::split_filesmethod ondatafusion-catalog/datasource::file_groups::FileGroup.Verified workspace-wide:
grep -rn "split_files" --include="*.rs")datafusion/catalog-listing/src/helpers.rs::tests::test_split_filesare calls onFileGroupvalues (files.clone().split_files(N)), not the deprecated free function — they exerciseFileGroup::split_filescorrectly.datafusion/catalog-listing/src/table.rsalso call theFileGroupmethod.cargo check -p datafusion-catalog-listingis clean (no warnings after also dropping the now-unuseduse std::mem;).cargo test -p datafusion-catalog-listing test_split_filespasses.This is a 36-line pure deletion: 35 lines for the function body plus the
use std::mem;import. Replaces only — the public methodFileGroup::split_filesalready exists atdatafusion/datasource/src/file_groups.rs:454and is what callers use.Test plan
cargo check -p datafusion-catalog-listing✓ (clean)cargo test -p datafusion-catalog-listing test_split_files✓ 1 passedgrep -rn "helpers::split_files\|use.*helpers::{.*split_files" datafusion/→ 0 matches after this change(e of in-tree call sites verified before edit via workspace grep; revisited after edit.)AI assistance
This patch was drafted with the help of an AI coding assistant. The diff was reviewed line by line before submission and the change was verified independently (cargo check + a focused cargo test run).
Signed-off-by: Dodothereal [email protected]