Repository navigation
chore(expr): remove deprecated Filter::try_new_with_having (Closes #23080 - partial) - #23145
Merged
alamb merged 1 commit intoJun 24, 2026
Conversation
…ache#23080 - partial) Filter::try_new_with_having has been deprecated since 48.0.0 in favor of Filter::try_new. A grep across the workspace confirms zero remaining callers and zero public re-exports — the function is definition-only. With DataFusion now on 55.x, the 6-major-version grace period cited by the API-health policy is past due. AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently. Generated-by: Anthropic Claude Signed-off-by: Dodothereal <[email protected]>
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
alamb
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23080
Summary
Removes
Filter::try_new_with_having, deprecated since 48.0.0 ("Usetry_newinstead"). A grep across the workspace confirms zero remaining callers and zero public re-exports — the method is definition-only. The 6-major-version grace period cited by the API-health policy is past due (we are now on 55.x).Test plan
git grep -nE 'try_new_with_having'returns no matches in source or docs (only the removed definition site).AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently.
Signed-off-by: Dodothereal [email protected]