Repository navigation
chore(physical-plan): remove deprecated RowIndex struct (Closes #23080 - partial) - #23143
Merged
Merged
Conversation
…e#23080 - partial) The RowIndex struct has been deprecated since 46.0.0 and was never wired into the public mod tree (sorts/index.rs was a dead file in the sources tree — declared nowhere as `mod index`, only its comments mention the type). A grep across the workspace confirms zero remaining callers and zero public re-exports. With DataFusion now on 55.x, the 6-major-version grace period cited by the API-health policy is past due. AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently. Generated-by: Anthropic Claude Signed-off-by: Dodothereal <[email protected]>
alamb
approved these changes
Jun 24, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Dodothereal -- love this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #23080
Summary
Removes the deprecated
RowIndexstruct fromdatafusion-physical-plan. The wholedatafusion/physical-plan/src/sorts/index.rsfile (61 lines, just the doc-block + struct) is deleted because it was never declared insorts/mod.rsand never re-exported viapub use— it was a dead file already. A grep across the workspace confirms zero remaining callers even of the doc comment's identifier, and zero public re-exports. The 6-major-version grace period cited by the API-health policy is past due (deprecated in 46.0.0, we are now on 55.x).Test plan
git grep -nE '\bRowIndex\b'returns no matches in source or docs (false-positives filtered:FileRowIndexFuncis a separate, undeprecated symbol).sorts/mod.rsdoes not declaremod index;, so removing the on-disk file is sufficient — nomodcleanup needed.datafusion-physical-plancrate still builds cleanly across all other sort modules.AI assistance: drafted with the help of an Anthropic coding assistant. Diff was reviewed line by line before submission, and the change was verified independently.
Signed-off-by: Dodothereal [email protected]