Repository navigation
Add FixedSizeList support for recursive struct schema adaptation #22980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b803a42
feat: enhance runtime casting for FixedSizeList and improve planner/r…
kosiew 0e82dcb
feat: add downcast_array macro for improved type safety in casting
kosiew 62c5adf
fix: close FixedSizeList size-mismatch loophole in nested_struct.rs
kosiew b561ef9
refactor: rename create_fsl_test_fields to create_fixed_size_list_tes…
kosiew 3286a0c
feat(tests): add regression and parity tests for FixedSizeList behavior
kosiew 38bdcf7
chore: refactor code for improved clarity and reduced redundancy
kosiew d8c1b17
feat: refactor nested_struct to use Arrow methods and remove downcast…
kosiew 70237b3
feat: enhance data type validation with improved fallback structure
kosiew 040691b
feat(nested_struct): add targeted fallback comments for FixedSizeList…
kosiew ced5b41
feat(nested_struct): refine compatibility checks and restructure cast…
kosiew dd00ef9
Merge branch 'main' into schema-evolution-02-20835
alamb d943826
Merge branch 'main' into schema-evolution-02-20835
kosiew 96ab349
feat(datafusion): simplify nested struct handling by removing compati…
kosiew a59ede7
feat: add FixedSizeList Parquet E2E coverage
kosiew 6600725
feat: replace panicking FixedSizeListArray::new with fallible try_new
kosiew 8b0c478
docs: add mention of equal-width FixedSizeList
kosiew 39ce782
Merge branch 'schema-evolution-02-20835' of github.com:kosiew/datafus…
kosiew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(nested_struct): refine compatibility checks and restructure cast…
…ing logic - Removed fixed-size-list compatibility check from the normal cast path. - Moved compatibility guard into the null-parent retry path only. - Adjusted cast_struct_column all-null fast path to follow struct compatibility validation, ensuring all-null structs reject missing non-nullable fields.
- Loading branch information
commit ced5b4143423ac532cfbefddf9a3eff7d6821c7a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still dont agree with having this validate call on the cast path
we dont do anything similar for other list types even though they could technically contain invalid data (that cant be casted) in a non-empty null slot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the validation.