Repository navigation
fix ^ evaluates as bitwise XOR instead of exponentiation - #22314
Merged
Merged
Conversation
Dandandan
reviewed
May 18, 2026
Dandandan
approved these changes
May 19, 2026
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Oct 14, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - None; documentation fix. Follows up apache#22314. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> The operators page documents `#` as bitwise xor, "interchangeable with `^`". On `main`, `SELECT 5 # 3;` fails with the default dialect (`ParserError("No infix parser for token Sharp ...")`); `#` is only xor in the PostgreSQL and Redshift dialects. The page describes the default dialect, where `^` is xor. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> The xor section and its index entry now document `^` instead of `#`, with the current column name (`BIT_XOR`) in the example output. Per review, the page sticks to the default dialect rather than listing per-dialect exceptions. ## What is the testing strategy for this PR? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'. If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it. You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised. --> Ran the new example against `datafusion-cli` built from `main`; `./ci/scripts/doc_prettier_check.sh` passes. Docs only, no test. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. --> Documentation only. Generated with Claude Code (claude-opus-5-5). It came from running the documented SQL examples against `main`, not from an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
^evaluates as bitwise XOR instead of exponentiation #22252.Rationale for this change
In PostgreSQL, the
^operator represents exponentiation, but DataFusion was interpreting it as bitwise XOR. This caused PostgreSQL-dialect queries such asSELECT 2 ^ 3;to return1instead of8.This change aligns DataFusion's PostgreSQL SQL semantics with PostgreSQL for this operator while preserving existing non-PostgreSQL behavior.
What changes are included in this PR?
BinaryOperator::PGExpduring SQL expression lowering.^expressions to the built-inpower(left, right)scalar function instead of treating them as bitwise XOR.^behavior unchanged.#.SELECT 2 ^ 3;under the PostgreSQL parser dialect.Are these changes tested?
Yes.
Added a regression test in scalar.slt to verify that PostgreSQL-dialect
^is evaluated as exponentiation.Validated with:
cargo test -p datafusion-sqllogictest --test sqllogictests scalarAre there any user-facing changes?
Yes.
For the PostgreSQL SQL parser dialect,
^now behaves as exponentiation instead of bitwise XOR, matching PostgreSQL semantics. Generic-dialect behavior is unchanged, and PostgreSQL bitwise XOR remains available through#.