fix: avoid internal errors for OneOf signature mismatches - #21032

Three categories of fallout from the OneOf-signature-diagnostics
cherry-pick that the upstream PR resolved via apache#20605 (formatting cleanup)
but apache#20605 isn't on 52.5.0:

1. Two unused imports in datafusion-expr's test module (`IntervalUnit`,
   `logical_int64`) that compile-fail under `-D warnings` and trip clippy
   + lib-test builds. Dropped from the test imports in
   type_coercion/functions.rs.

2. Two sql-integration tests assert on the old
   `user-defined coercion failed with "..."` wording; updated to the new
   `failed with: ...` shape.

3. Eight sqllogictest expected-error patterns across arrow_typeof.slt,
   encoding.slt, expr.slt, scalar.slt, and datetime/timestamps.slt
   asserted on the old
   `Internal error: Expect TypeSignatureClass::X but received NativeType::Y`
   shape; updated to the new
   `Function 'NAME' requires TypeSignatureClass::X, but received Y (DataType: Y)`
   shape.

Cherry-pick of apache#21032. Adapted for 52.5.0:

- Two unused imports in datafusion-expr's test module (`IntervalUnit`,
  `logical_int64`) compile-fail under -D warnings; dropped.
- Two sql-integration tests and several sqllogictest expected-error
  patterns assumed the friendlier Display impl from apache#20605
  was already on 52.5.0 (it isn't); updated those patterns to the
  pre-apache#20605 verbose `TypeSignatureClass::Native(LogicalType(...))` shape
  and to the post-apache#21032 `failed with: ...` (no quoted inner message)
  shape.
- Also includes the author's own follow-up CI fix (was a separate commit
  upstream, folded here).

Signed-off-by: yaommen <[email protected]>

Cherry-pick of apache#21032. Adapted for 52.5.0:

- Two unused imports in datafusion-expr's test module (`IntervalUnit`,
  `logical_int64`) compile-fail under -D warnings; dropped.
- Two sql-integration tests and several sqllogictest expected-error
  patterns assumed the friendlier Display impl from apache#20605
  was already on 52.5.0 (it isn't); updated those patterns to the
  pre-apache#20605 verbose `TypeSignatureClass::Native(LogicalType(...))` shape
  and to the post-apache#21032 `failed with: ...` (no quoted inner message)
  shape.
- Also includes the author's own follow-up CI fix (was a separate commit
  upstream, folded here).

Signed-off-by: yaommen <[email protected]>

Cherry-pick of apache#21032. Adapted for 52.5.0:

- Two unused imports in datafusion-expr's test module (`IntervalUnit`,
  `logical_int64`) compile-fail under -D warnings; dropped.
- Two sql-integration tests and several sqllogictest expected-error
  patterns assumed the friendlier Display impl from apache#20605
  was already on 52.5.0 (it isn't); updated those patterns to the
  pre-apache#20605 verbose `TypeSignatureClass::Native(LogicalType(...))` shape
  and to the post-apache#21032 `failed with: ...` (no quoted inner message)
  shape.
- Also includes the author's own follow-up CI fix (was a separate commit
  upstream, folded here).

Signed-off-by: yaommen <[email protected]>
(cherry picked from commit f478cdc)

Cherry-pick of apache#21032. Adapted for 52.5.0:

- Two unused imports in datafusion-expr's test module (`IntervalUnit`,
  `logical_int64`) compile-fail under -D warnings; dropped.
- Two sql-integration tests and several sqllogictest expected-error
  patterns assumed the friendlier Display impl from apache#20605
  was already on 52.5.0 (it isn't); updated those patterns to the
  pre-apache#20605 verbose `TypeSignatureClass::Native(LogicalType(...))` shape
  and to the post-apache#21032 `failed with: ...` (no quoted inner message)
  shape.
- Also includes the author's own follow-up CI fix (was a separate commit
  upstream, folded here).

Signed-off-by: yaommen <[email protected]>
(cherry picked from commit f478cdc)

## Which issue does this PR close?

Part of apache#20501.

This is a deliberately narrow slice of that issue, and it is the slice a
maintainer previously asked for: apache#21032 attempted this fix as a large
change (it also reworked `sum`/`avg` diagnostics and the public
`first_value`/`last_value`/`nth_value` arity contracts), was asked to be
split up, and then went stale. This PR is **one behaviour change and
nothing else**.

## Rationale for this change

`get_valid_types_with_udf` reports "no `OneOf` branch matched" with
`internal_err!`. Every alternative signature failing means the *caller*
passed the wrong number or types of arguments — a user mistake — yet the
user is told:

> This issue was likely caused by a bug in DataFusion's code. Please
help us to resolve this by filing a bug report in our issue tracker: ...

So an ordinary SQL typo invites a bug report, and the failure surfaces
as `Internal error: ...` even though nothing internal went wrong. The
maintainer comment on apache#20070 named exactly this ("Can try to fix the
display + internal error reference").

### Before / after

`SELECT substr(1, 2)`

Before:

```text
Error during planning: Internal error: Function 'substr' failed to match any signature, errors: Error during planning: Function 'substr' requires String, but received Int64 (DataType: Int64).,Error during planning: Function 'substr' expects 3 arguments but received 2.
This issue was likely caused by a bug in DataFusion's code. Please help us to resolve this by filing a bug report in our issue tracker: https://github.com/apache/datafusion/issues
```

After:

```text
Error during planning: Function 'substr' failed to match any signature, errors: Error during planning: Function 'substr' requires String, but received Int64 (DataType: Int64).,Error during planning: Function 'substr' expects 3 arguments but received 2.
```

The message body, the candidate signatures, and the trailing "No
function matches the given name and argument types ... You might need to
add explicit type casts." line are all unchanged. Only the `Internal
error` kind and the bug-report boilerplate are gone.

## What changes are included in this PR?

- `datafusion/expr/src/type_coercion/functions.rs`: return `plan_err!`
instead of `internal_err!` when every `OneOf` branch rejects the
arguments. One line of behaviour change.
- A unit test covering that failure. It mirrors `substr`'s real
signature, so one branch fails on the argument type and the other on the
arity.
- Ten `sqllogictest` expectations that asserted the old user-visible
text, in `array/array_range.slt`, `spark/math/round.slt`, `errors.slt`
and `math.slt`.

## Are these changes tested?

Yes.

- The new unit test fails on `main` and passes with the change; `cargo
test -p datafusion-expr --lib` is 282 passed, 0 failed.
- `cargo fmt --all --check` is clean.
- I audited every other expectation of this message. The remaining ones
— `functions.slt`, `aggregate.slt`, `string_literal.slt`,
`named_arguments.slt`, and one assertion in
`datafusion/optimizer/src/analyzer/type_coercion.rs` — match on a
substring that does not include the removed prefix, so they are
unaffected. No `sqllogictest` file asserted the "This issue was likely
caused by a bug..." boilerplate.

I could not run the full `sqllogictest` suite locally (it needs a full
`datafusion-core` build), so CI is the verification for the four updated
`.slt` files.

## Scope

Deliberately left out, to keep this reviewable:

- the message is still verbose and still prefixes every branch error
with `Error during planning:` — that is apache#19004;
- `errors.join(",")` still runs the branch errors together without a
separator, which is why the after-message reads `...(DataType:
Int64).,Error during planning: ...`;
- the arity phrasing suggested on apache#20070 (`log expects 1 to 2 arguments,
got 3`) is a separate improvement.

Happy to follow up on any of those in separate PRs.