Simplify logic for memory pressure partial emit from ordered group by#20559
Draft
alamb wants to merge 3 commits intoapache:mainfrom
Draft
Simplify logic for memory pressure partial emit from ordered group by#20559alamb wants to merge 3 commits intoapache:mainfrom
alamb wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GroupOrderingPartial::remove_groupswhen Partial aggregate with PartiallySorted hits memory pressure #20445Rationale for this change
I found the formulation of the fix in #20446 hard to follow (see #20446 (review) for details).
Basically the meaning of emit_to and 0 are inverted in this case.
What changes are included in this PR?
Pull the logic of what to emit into its own function with more comments that I think make it clearer what is going on
Are these changes tested?
Yes by existing tests
Are there any user-facing changes?