[branch-52] Fix incorrect SortExec removal before AggregateExec (#20247)#20507
Merged
alamb merged 3 commits intoapache:branch-52from Feb 25, 2026
Merged
[branch-52] Fix incorrect SortExec removal before AggregateExec (#20247)#20507alamb merged 3 commits intoapache:branch-52from
SortExec removal before AggregateExec (#20247)#20507alamb merged 3 commits intoapache:branch-52from
Conversation
…pache#20247) - Fixes apache#20244 This is an alternatative to - apache#20245 Wrong answers bug was exposed by apache#19287 in 52. See apache#20244 and backstory here - apache#19287 (comment) Fix the bug by properly implemnting Yes, a new test is added A bug is fixed --------- Co-authored-by: Mustafa Akur <[email protected]>
This was referenced Feb 23, 2026
github-actions
bot
added
optimizer
Contributor
Author
|
I merged up to resolve a conflit |
Contributor
Author
|
Thanks again for the review @comphead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See issues
What changes are included in this PR?
SortExecremoval beforeAggregateExec(option 2) #20247Are these changes tested?
By CI
Are there any user-facing changes?