fix: gc string view arrays in RepartitionExec#20500
Draft
Samyak2 wants to merge 2 commits intoapache:mainfrom
Draft
fix: gc string view arrays in RepartitionExec#20500Samyak2 wants to merge 2 commits intoapache:mainfrom
Samyak2 wants to merge 2 commits intoapache:mainfrom
Conversation
Fixes apache#20491 - Took the fix from `ExternalSorter` introduced in apache#14823 - If any `StringViewArray` columns are present in the repartitioned input, we gc them to reduce duplicate tracking of the same string view buffer. - Fixes over-counting when there's a `RepartitionExec` above a partial agg on a `StringViewArray` column.
This is not needed for round robin repartition
Samyak2
force-pushed
the
fix-repartition-string-view-counting
branch
from
6a1547d to
471de13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Utf8View/StringViewArray#20491.Rationale for this change
RepartitionExecabove a partial agg on aStringViewArraycolumn.ExternalSorterintroduced in Fix: External sort failing onStringViewdue to shared buffers #14823What changes are included in this PR?
StringViewArraycolumns are present in the repartitioned input, we gc them to reduce duplicate tracking of the same string view buffer.Are these changes tested?
Checked that this fixes the issue reported in #20491
Are there any user-facing changes?
No