docs: Document that adding new optimizer rules are expensive#20348
Merged
adriangb merged 3 commits intoapache:mainfrom Feb 23, 2026
Merged
docs: Document that adding new optimizer rules are expensive#20348adriangb merged 3 commits intoapache:mainfrom
adriangb merged 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
optimizer
neilconway
approved these changes
Feb 15, 2026
adriangb
approved these changes
Feb 16, 2026
Contributor
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
Left a small suggestion
2010YOUY01
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As part of PR reviews, it seems like it is not obvious to some contributors that there is a non trivial cost to adding new optimizer rules. Let's add that knowledge into the codebase as comments, so it may be less of a surprise
What changes are included in this PR?
Add comments
Are these changes tested?
N/A
Are there any user-facing changes?
No this is entirely internal comments oly