[branch 52] Fix grouping set subset satisfaction#19855
Merged
gabotechs merged 1 commit intoapache:branch-52from Jan 16, 2026
Merged
[branch 52] Fix grouping set subset satisfaction#19855gabotechs merged 1 commit intoapache:branch-52from
gabotechs merged 1 commit intoapache:branch-52from
Conversation
## Summary - Fixes incorrect results from ROLLUP/CUBE/GROUPING SETS queries when using multiple partitions - The subset satisfaction optimization was incorrectly allowing hash partitioning on fewer columns to satisfy requirements that include `__grouping_id` - This caused partial aggregates from different partitions to be finalized independently, producing duplicate grand totals Closes apache#19849
15 tasks
alamb
approved these changes
Jan 16, 2026
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Feb 9, 2026
This reverts commit eb00fe2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #19853 into
branch-52