Upgrade hashbrown to 0.16 by Dandandan · Pull Request #19554 · apache/datafusion

Dandandan · 2025-12-29T18:42:20Z

Which issue does this PR close?

Closes Upgrade to hashbrown 0.16.1: migrate from hashbrown::raw::RawTable to hashbrown::hash_table::HashTable #13433

Rationale for this change

Keep up to date with hashbrown and possible (performance) improvements, remove the rawtable functionality.

What changes are included in this PR?

Upgrading, fixing case of nondeterminism in HashSet usage.

Are these changes tested?

Yes existiing tests.

Are there any user-facing changes?

No.

Dandandan · 2025-12-29T18:51:00Z

run benchmarks

alamb-ghbot · 2025-12-29T18:51:08Z

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing upgrade_hashbrown2 (1b6e84e) to 673d7c9 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

Dandandan · 2025-12-29T18:51:28Z

run benchmark tpch

alamb-ghbot · 2025-12-29T19:32:05Z

🤖: Benchmark completed

Details

Comparing HEAD and upgrade_hashbrown2
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ upgrade_hashbrown2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │  2561.83 ms │         2387.67 ms │ +1.07x faster │
│ QQuery 1     │  1059.39 ms │          962.90 ms │ +1.10x faster │
│ QQuery 2     │  2026.44 ms │         1908.76 ms │ +1.06x faster │
│ QQuery 3     │  1134.95 ms │         1192.11 ms │  1.05x slower │
│ QQuery 4     │  2261.78 ms │         2252.81 ms │     no change │
│ QQuery 5     │ 28730.75 ms │        28507.80 ms │     no change │
│ QQuery 6     │  3919.03 ms │         3910.93 ms │     no change │
│ QQuery 7     │  3626.55 ms │         3741.00 ms │     no change │
└──────────────┴─────────────┴────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                 ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                 │ 45320.71ms │
│ Total Time (upgrade_hashbrown2)   │ 44863.99ms │
│ Average Time (HEAD)               │  5665.09ms │
│ Average Time (upgrade_hashbrown2) │  5608.00ms │
│ Queries Faster                    │          3 │
│ Queries Slower                    │          1 │
│ Queries with No Change            │          4 │
│ Queries with Failure              │          0 │
└───────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ upgrade_hashbrown2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.47 ms │            2.06 ms │ +1.20x faster │
│ QQuery 1     │    49.32 ms │           49.37 ms │     no change │
│ QQuery 2     │   135.21 ms │          137.03 ms │     no change │
│ QQuery 3     │   152.11 ms │          152.67 ms │     no change │
│ QQuery 4     │  1073.43 ms │         1100.10 ms │     no change │
│ QQuery 5     │  1440.38 ms │         1338.93 ms │ +1.08x faster │
│ QQuery 6     │     1.98 ms │            2.02 ms │     no change │
│ QQuery 7     │    55.35 ms │           54.54 ms │     no change │
│ QQuery 8     │  1375.08 ms │         1447.86 ms │  1.05x slower │
│ QQuery 9     │  1783.62 ms │         1842.61 ms │     no change │
│ QQuery 10    │   344.80 ms │          365.97 ms │  1.06x slower │
│ QQuery 11    │   397.13 ms │          409.08 ms │     no change │
│ QQuery 12    │  1300.09 ms │         1271.23 ms │     no change │
│ QQuery 13    │  1978.83 ms │         1952.04 ms │     no change │
│ QQuery 14    │  1201.75 ms │         1249.00 ms │     no change │
│ QQuery 15    │  1196.16 ms │         1251.39 ms │     no change │
│ QQuery 16    │  2513.02 ms │         2538.00 ms │     no change │
│ QQuery 17    │  2469.49 ms │         2535.46 ms │     no change │
│ QQuery 18    │  5999.33 ms │         4864.98 ms │ +1.23x faster │
│ QQuery 19    │   123.51 ms │          120.14 ms │     no change │
│ QQuery 20    │  1924.10 ms │         1900.62 ms │     no change │
│ QQuery 21    │  2249.11 ms │         2208.44 ms │     no change │
│ QQuery 22    │  6868.93 ms │         3774.52 ms │ +1.82x faster │
│ QQuery 23    │ 24045.87 ms │        12183.73 ms │ +1.97x faster │
│ QQuery 24    │   218.05 ms │          204.65 ms │ +1.07x faster │
│ QQuery 25    │   478.10 ms │          479.17 ms │     no change │
│ QQuery 26    │   235.68 ms │          211.78 ms │ +1.11x faster │
│ QQuery 27    │  2715.18 ms │         2698.64 ms │     no change │
│ QQuery 28    │ 23960.96 ms │        24508.12 ms │     no change │
│ QQuery 29    │   962.94 ms │          971.21 ms │     no change │
│ QQuery 30    │  1330.57 ms │         1335.88 ms │     no change │
│ QQuery 31    │  1344.48 ms │         1349.19 ms │     no change │
│ QQuery 32    │  4788.91 ms │         4948.22 ms │     no change │
│ QQuery 33    │  6023.84 ms │         5507.74 ms │ +1.09x faster │
│ QQuery 34    │  5969.55 ms │         5602.95 ms │ +1.07x faster │
│ QQuery 35    │  1907.46 ms │         1933.55 ms │     no change │
│ QQuery 36    │    66.31 ms │           65.92 ms │     no change │
│ QQuery 37    │    44.62 ms │           46.00 ms │     no change │
│ QQuery 38    │    63.91 ms │           63.91 ms │     no change │
│ QQuery 39    │   102.81 ms │          102.02 ms │     no change │
│ QQuery 40    │    24.62 ms │           25.77 ms │     no change │
│ QQuery 41    │    23.09 ms │           23.08 ms │     no change │
│ QQuery 42    │    19.19 ms │           19.16 ms │     no change │
└──────────────┴─────────────┴────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Benchmark Summary                 ┃             ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ Total Time (HEAD)                 │ 108961.36ms │
│ Total Time (upgrade_hashbrown2)   │  92848.70ms │
│ Average Time (HEAD)               │   2533.99ms │
│ Average Time (upgrade_hashbrown2) │   2159.27ms │
│ Queries Faster                    │           9 │
│ Queries Slower                    │           2 │
│ Queries with No Change            │          32 │
│ Queries with Failure              │           0 │
└───────────────────────────────────┴─────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ upgrade_hashbrown2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 118.60 ms │          117.33 ms │     no change │
│ QQuery 2     │  28.90 ms │           26.40 ms │ +1.09x faster │
│ QQuery 3     │  37.10 ms │           37.91 ms │     no change │
│ QQuery 4     │  27.79 ms │           28.21 ms │     no change │
│ QQuery 5     │  87.60 ms │           86.60 ms │     no change │
│ QQuery 6     │  19.32 ms │           19.44 ms │     no change │
│ QQuery 7     │ 224.28 ms │          222.77 ms │     no change │
│ QQuery 8     │  38.69 ms │           34.14 ms │ +1.13x faster │
│ QQuery 9     │ 104.34 ms │           98.26 ms │ +1.06x faster │
│ QQuery 10    │  60.31 ms │           60.95 ms │     no change │
│ QQuery 11    │  17.44 ms │           18.68 ms │  1.07x slower │
│ QQuery 12    │  49.80 ms │           51.16 ms │     no change │
│ QQuery 13    │  45.67 ms │           47.20 ms │     no change │
│ QQuery 14    │  14.08 ms │           13.41 ms │     no change │
│ QQuery 15    │  24.09 ms │           23.80 ms │     no change │
│ QQuery 16    │  23.85 ms │           24.37 ms │     no change │
│ QQuery 17    │ 152.00 ms │          150.32 ms │     no change │
│ QQuery 18    │ 276.74 ms │          277.13 ms │     no change │
│ QQuery 19    │  36.77 ms │           38.95 ms │  1.06x slower │
│ QQuery 20    │  48.70 ms │           48.55 ms │     no change │
│ QQuery 21    │ 298.53 ms │          305.83 ms │     no change │
│ QQuery 22    │  17.05 ms │           17.19 ms │     no change │
└──────────────┴───────────┴────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                 ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                 │ 1751.64ms │
│ Total Time (upgrade_hashbrown2)   │ 1748.61ms │
│ Average Time (HEAD)               │   79.62ms │
│ Average Time (upgrade_hashbrown2) │   79.48ms │
│ Queries Faster                    │         3 │
│ Queries Slower                    │         2 │
│ Queries with No Change            │        17 │
│ Queries with Failure              │         0 │
└───────────────────────────────────┴───────────┘

alamb-ghbot · 2025-12-29T19:32:10Z

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing upgrade_hashbrown2 (7d3af7a) to 673d7c9 diff using: tpch
Results will be posted here when complete

Dandandan · 2025-12-29T19:33:32Z

run benchmarks

alamb · 2025-12-29T19:33:49Z

Cargo.lock


 [[package]]
 name = "hashbrown"
 version = "0.15.5"


looks like we still have an older hashbrown dependency, but this is a good step!

datafusion/physical-expr/src/expressions/case.rs

alamb-ghbot · 2025-12-29T19:45:04Z

🤖: Benchmark completed

Details

Comparing HEAD and upgrade_hashbrown2
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ upgrade_hashbrown2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 192.32 ms │          192.83 ms │     no change │
│ QQuery 2     │  94.19 ms │           94.00 ms │     no change │
│ QQuery 3     │ 126.48 ms │          118.61 ms │ +1.07x faster │
│ QQuery 4     │  76.41 ms │           76.28 ms │     no change │
│ QQuery 5     │ 170.77 ms │          176.96 ms │     no change │
│ QQuery 6     │  67.13 ms │           65.49 ms │     no change │
│ QQuery 7     │ 220.95 ms │          213.14 ms │     no change │
│ QQuery 8     │ 168.90 ms │          157.87 ms │ +1.07x faster │
│ QQuery 9     │ 224.98 ms │          219.63 ms │     no change │
│ QQuery 10    │ 179.65 ms │          180.50 ms │     no change │
│ QQuery 11    │  72.34 ms │           71.68 ms │     no change │
│ QQuery 12    │ 114.56 ms │          118.44 ms │     no change │
│ QQuery 13    │ 222.41 ms │          208.48 ms │ +1.07x faster │
│ QQuery 14    │  92.98 ms │           89.73 ms │     no change │
│ QQuery 15    │ 118.02 ms │          121.47 ms │     no change │
│ QQuery 16    │  55.15 ms │           54.35 ms │     no change │
│ QQuery 17    │ 267.05 ms │          271.41 ms │     no change │
│ QQuery 18    │ 310.07 ms │          313.21 ms │     no change │
│ QQuery 19    │ 129.04 ms │          137.63 ms │  1.07x slower │
│ QQuery 20    │ 122.56 ms │          122.16 ms │     no change │
│ QQuery 21    │ 256.50 ms │          265.97 ms │     no change │
│ QQuery 22    │  42.08 ms │           41.67 ms │     no change │
└──────────────┴───────────┴────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                 ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                 │ 3324.53ms │
│ Total Time (upgrade_hashbrown2)   │ 3311.53ms │
│ Average Time (HEAD)               │  151.11ms │
│ Average Time (upgrade_hashbrown2) │  150.52ms │
│ Queries Faster                    │         3 │
│ Queries Slower                    │         1 │
│ Queries with No Change            │        18 │
│ Queries with Failure              │         0 │
└───────────────────────────────────┴───────────┘

alamb-ghbot · 2025-12-29T19:45:07Z

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing upgrade_hashbrown2 (7d3af7a) to 673d7c9 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

alamb-ghbot · 2025-12-29T20:10:17Z

🤖: Benchmark completed

Details

Comparing HEAD and upgrade_hashbrown2
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ upgrade_hashbrown2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │  2522.36 ms │         2333.15 ms │ +1.08x faster │
│ QQuery 1     │  1030.44 ms │          945.64 ms │ +1.09x faster │
│ QQuery 2     │  2046.31 ms │         1907.16 ms │ +1.07x faster │
│ QQuery 3     │  1128.14 ms │         1155.07 ms │     no change │
│ QQuery 4     │  2263.75 ms │         2291.47 ms │     no change │
│ QQuery 5     │ 28093.82 ms │        28217.83 ms │     no change │
│ QQuery 6     │  3907.78 ms │         3891.44 ms │     no change │
│ QQuery 7     │  3528.07 ms │         3511.39 ms │     no change │
└──────────────┴─────────────┴────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                 ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                 │ 44520.66ms │
│ Total Time (upgrade_hashbrown2)   │ 44253.16ms │
│ Average Time (HEAD)               │  5565.08ms │
│ Average Time (upgrade_hashbrown2) │  5531.65ms │
│ Queries Faster                    │          3 │
│ Queries Slower                    │          0 │
│ Queries with No Change            │          5 │
│ Queries with Failure              │          0 │
└───────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ upgrade_hashbrown2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.07 ms │            2.43 ms │  1.17x slower │
│ QQuery 1     │    50.03 ms │           49.39 ms │     no change │
│ QQuery 2     │   133.93 ms │          132.07 ms │     no change │
│ QQuery 3     │   153.03 ms │          150.50 ms │     no change │
│ QQuery 4     │  1052.42 ms │         1072.80 ms │     no change │
│ QQuery 5     │  1446.07 ms │         1348.55 ms │ +1.07x faster │
│ QQuery 6     │     2.02 ms │            2.06 ms │     no change │
│ QQuery 7     │    58.22 ms │           57.22 ms │     no change │
│ QQuery 8     │  1411.21 ms │         1426.37 ms │     no change │
│ QQuery 9     │  1832.47 ms │         1841.28 ms │     no change │
│ QQuery 10    │   362.41 ms │          359.14 ms │     no change │
│ QQuery 11    │   394.83 ms │          403.76 ms │     no change │
│ QQuery 12    │  1331.93 ms │         1279.03 ms │     no change │
│ QQuery 13    │  1958.86 ms │         1982.78 ms │     no change │
│ QQuery 14    │  1236.90 ms │         1251.42 ms │     no change │
│ QQuery 15    │  1236.39 ms │         1209.84 ms │     no change │
│ QQuery 16    │  2484.89 ms │         2532.81 ms │     no change │
│ QQuery 17    │  2459.85 ms │         2514.44 ms │     no change │
│ QQuery 18    │  5302.27 ms │         4839.06 ms │ +1.10x faster │
│ QQuery 19    │   120.97 ms │          125.00 ms │     no change │
│ QQuery 20    │  1937.35 ms │         1873.46 ms │     no change │
│ QQuery 21    │  2200.77 ms │         2170.98 ms │     no change │
│ QQuery 22    │  3800.90 ms │         3743.52 ms │     no change │
│ QQuery 23    │ 12349.72 ms │        12186.07 ms │     no change │
│ QQuery 24    │   214.62 ms │          216.10 ms │     no change │
│ QQuery 25    │   482.05 ms │          470.95 ms │     no change │
│ QQuery 26    │   216.11 ms │          212.92 ms │     no change │
│ QQuery 27    │  2689.65 ms │         2687.35 ms │     no change │
│ QQuery 28    │ 23506.91 ms │        24310.98 ms │     no change │
│ QQuery 29    │   934.66 ms │          942.32 ms │     no change │
│ QQuery 30    │  1318.09 ms │         1299.52 ms │     no change │
│ QQuery 31    │  1324.91 ms │         1343.18 ms │     no change │
│ QQuery 32    │  5224.11 ms │         4967.57 ms │     no change │
│ QQuery 33    │  5926.71 ms │         5693.79 ms │     no change │
│ QQuery 34    │  5912.64 ms │         5817.39 ms │     no change │
│ QQuery 35    │  1903.25 ms │         1892.05 ms │     no change │
│ QQuery 36    │    67.52 ms │           64.39 ms │     no change │
│ QQuery 37    │    43.58 ms │           45.37 ms │     no change │
│ QQuery 38    │    66.48 ms │           62.70 ms │ +1.06x faster │
│ QQuery 39    │   103.95 ms │          102.83 ms │     no change │
│ QQuery 40    │    26.20 ms │           26.60 ms │     no change │
│ QQuery 41    │    23.57 ms │           23.26 ms │     no change │
│ QQuery 42    │    19.82 ms │           18.79 ms │ +1.05x faster │
└──────────────┴─────────────┴────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                 ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                 │ 93324.39ms │
│ Total Time (upgrade_hashbrown2)   │ 92752.04ms │
│ Average Time (HEAD)               │  2170.33ms │
│ Average Time (upgrade_hashbrown2) │  2157.02ms │
│ Queries Faster                    │          4 │
│ Queries Slower                    │          1 │
│ Queries with No Change            │         38 │
│ Queries with Failure              │          0 │
└───────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ upgrade_hashbrown2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 117.75 ms │          120.18 ms │     no change │
│ QQuery 2     │  29.32 ms │           27.27 ms │ +1.08x faster │
│ QQuery 3     │  38.02 ms │           32.70 ms │ +1.16x faster │
│ QQuery 4     │  28.19 ms │           28.77 ms │     no change │
│ QQuery 5     │  87.05 ms │           87.23 ms │     no change │
│ QQuery 6     │  19.51 ms │           19.65 ms │     no change │
│ QQuery 7     │ 228.33 ms │          223.48 ms │     no change │
│ QQuery 8     │  37.95 ms │           37.84 ms │     no change │
│ QQuery 9     │ 104.75 ms │          104.61 ms │     no change │
│ QQuery 10    │  62.92 ms │           64.10 ms │     no change │
│ QQuery 11    │  17.44 ms │           18.51 ms │  1.06x slower │
│ QQuery 12    │  50.42 ms │           50.10 ms │     no change │
│ QQuery 13    │  45.82 ms │           47.60 ms │     no change │
│ QQuery 14    │  14.04 ms │           13.68 ms │     no change │
│ QQuery 15    │  24.34 ms │           24.28 ms │     no change │
│ QQuery 16    │  23.85 ms │           24.20 ms │     no change │
│ QQuery 17    │ 148.32 ms │          148.71 ms │     no change │
│ QQuery 18    │ 281.99 ms │          280.27 ms │     no change │
│ QQuery 19    │  37.63 ms │           38.79 ms │     no change │
│ QQuery 20    │  49.03 ms │           48.01 ms │     no change │
│ QQuery 21    │ 315.66 ms │          313.15 ms │     no change │
│ QQuery 22    │  17.38 ms │           17.64 ms │     no change │
└──────────────┴───────────┴────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                 ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                 │ 1779.73ms │
│ Total Time (upgrade_hashbrown2)   │ 1770.75ms │
│ Average Time (HEAD)               │   80.90ms │
│ Average Time (upgrade_hashbrown2) │   80.49ms │
│ Queries Faster                    │         2 │
│ Queries Slower                    │         1 │
│ Queries with No Change            │        19 │
│ Queries with Failure              │         0 │
└───────────────────────────────────┴───────────┘

alamb · 2025-12-30T12:12:04Z

Nice -- thanks @Dandandan

Dandandan added 4 commits December 29, 2025 19:41

Upgrade hashbrown to 0.16

cac8914

Upgrade hashbrown to 0.16

c2ec4ed

Upgrade hashbrown to 0.16

b35306c

Upgrade hashbrown to 0.16

97fe22a

github-actions bot added the common Related to common crate label Dec 29, 2025

Upgrade hashbrown to 0.16

1b6e84e

github-actions bot added the physical-expr Changes to the physical-expr crates label Dec 29, 2025

Fix nondeterministic behavior

a0d74ec

Dandandan marked this pull request as ready for review December 29, 2025 19:06

Update test

7d3af7a

github-actions bot added the functions Changes to functions implementation label Dec 29, 2025

alamb approved these changes Dec 29, 2025

View reviewed changes

Dandandan added 2 commits December 29, 2025 20:56

Fix 2

e6fea00

Fix 2

646da34

Dandandan added 7 commits December 29, 2025 22:17

Fix 3

52361bb

Fix 3

b39ab4c

Fix 3

6267b1e

Simplify

0c34cb6

Simplify

417f7d0

Simplify

6472572

WIP

8e80b3d

Dandandan added this pull request to the merge queue Dec 30, 2025

Merged via the queue into apache:main with commit a6fd5cc Dec 30, 2025
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Upgrade hashbrown to 0.16#19554

Upgrade hashbrown to 0.16#19554
Dandandan merged 16 commits intoapache:mainfrom
Dandandan:upgrade_hashbrown2

Dandandan commented Dec 29, 2025 •

edited

Loading

Uh oh!

Dandandan commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

Dandandan commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

Dandandan commented Dec 29, 2025

Uh oh!

alamb Dec 29, 2025

Uh oh!

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

Uh oh!

alamb commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

Dandandan commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Dandandan commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

Dandandan commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

Dandandan commented Dec 29, 2025

Uh oh!

alamb Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

alamb-ghbot commented Dec 29, 2025

Uh oh!

Uh oh!

alamb commented Dec 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Dandandan commented Dec 29, 2025 •

edited

Loading