Update remaining crates to rust 2024 edition#19361
Merged
timsaucer merged 3 commits intoapache:mainfrom Dec 17, 2025
Merged
Conversation
github-actions
bot
added
sql
Jefffrey
approved these changes
Dec 17, 2025
Dandandan
approved these changes
Dec 17, 2025
Contributor
|
Nice work! |
timsaucer
force-pushed
the
chore/upgrade-rust-2024-group-8
branch
from
e28c247 to
0effc95
Compare
Member
Author
|
I'm going to merge now and then if any small CI failures happen on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #15804
Rationale for this change
Now that we are on MSRV 1.88 we can use rust edition 2024, which brings let chains and other nice features. It also improves
unsafechecking. In order to introduce these changes in slower way instead of one massive PR that is too difficult to manage we are updating a few crates at a time.What changes are included in this PR?
Updates these crates to 2024.
Are these changes tested?
Existing unit tests. There are no functional code changes.
Are there any user-facing changes?
None.
Note
It is recommended to review with the ignore whitespace setting: https://github.com/apache/datafusion/pull/19361/files?w=1