Repository navigation
Conversation
Closed
37 of 38 tasks
Jefffrey
reviewed
Nov 15, 2025
Jefffrey
approved these changes
Nov 15, 2025
jizezhang
pushed a commit
to jizezhang/datafusion
that referenced
this pull request
Nov 15, 2025
…apache#18714) ## Which issue does this PR close? - Part of parent issue apache#18503 ## What changes are included in this PR? enforce clippy lint `needless_pass_by_value` to `datafusion-spark` ## Are these changes tested? yes ## Are there any user-facing changes? no
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
…apache#18714) ## Which issue does this PR close? - Part of parent issue apache#18503 ## What changes are included in this PR? enforce clippy lint `needless_pass_by_value` to `datafusion-spark` ## Are these changes tested? yes ## Are there any user-facing changes? no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
clippy::needless_pass_by_valuein all datafusion crates #18503What changes are included in this PR?
enforce clippy lint
needless_pass_by_valuetodatafusion-sparkAre these changes tested?
yes
Are there any user-facing changes?
no