Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
clippy + review feedback
  • Loading branch information
2010YOUY01 committed Oct 27, 2025
commit 5d32fff05dd2d991060ecfd5c0c9c75dd5766d3a
2 changes: 1 addition & 1 deletion datafusion/core/tests/parquet/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ use datafusion::{
prelude::{ParquetReadOptions, SessionConfig, SessionContext},
};
use datafusion_expr::{Expr, LogicalPlan, LogicalPlanBuilder};
use datafusion_physical_plan::{metrics::MetricValue, Metric};
use datafusion_physical_plan::metrics::MetricValue;
use parquet::arrow::ArrowWriter;
use parquet::file::properties::{EnabledStatistics, WriterProperties};
use std::sync::Arc;
Expand Down
7 changes: 3 additions & 4 deletions datafusion/physical-plan/src/metrics/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -622,10 +622,9 @@ impl MetricValue {
.map(|nanos| nanos as usize)
.unwrap_or(0),
// This function is a utility for aggregating metrics, for complex metric
// like `PruningMetrics`, implement it inside `MetricsSet` directly.
Self::PruningMetrics { .. } => {
unreachable!()
}
// like `PruningMetrics`, this function is not supposed to get called.
// Metrics aggregation for them are implemented inside `MetricsSet` directly.
Self::PruningMetrics { .. } => 0,
Self::Custom { value, .. } => value.as_usize(),
}
}
Expand Down