Add integration test for IO operations for listing tables queries#18229
Merged
alamb merged 1 commit intoapache:mainfrom Oct 26, 2025
Merged
Add integration test for IO operations for listing tables queries#18229alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
core
alamb
force-pushed
the
alamb/object_store_trace_tests
branch
3 times, most recently
from
b2924b7 to
3db4b0e
Compare
alamb
force-pushed
the
alamb/object_store_trace_tests
branch
from
3db4b0e to
ba4e802
Compare
alamb
changed the title
alamb
force-pushed
the
alamb/object_store_trace_tests
branch
from
ba4e802 to
981bc5c
Compare
alamb
commented
Oct 24, 2025
| @r" | ||
| RequestCountingObjectStore() | ||
| Total Requests: 2 | ||
| - HEAD path=csv_table.csv |
Contributor
Author
There was a problem hiding this comment.
the idea is here we can see what object store requests are made for various operations
Contributor
There was a problem hiding this comment.
Great, we can add test if we have optimization to verify after this merged.
alamb
force-pushed
the
alamb/object_store_trace_tests
branch
from
981bc5c to
4b4a9ec
Compare
This was referenced Oct 24, 2025
zhuqi-lucas
approved these changes
Oct 25, 2025
Contributor
zhuqi-lucas
left a comment
zhuqi-lucas
left a comment
There was a problem hiding this comment.
LGTM, great work, thank you @alamb !
alamb
commented
Oct 25, 2025
| ------- Object Store Request Summary ------- | ||
| RequestCountingObjectStore() | ||
| Total Requests: 4 | ||
| - LIST prefix=data |
Contributor
Author
There was a problem hiding this comment.
@BlakeOrth here is where I envision we can add tests for the current (and potential changes) for LISTING with partitioned tables
Contributor
Author
|
Let's start with this set of tests and we can iterate as we use them to show other features (like listing tables with partitions) |
Contributor
Author
|
Thanks @zhuqi-lucas |
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…ache#18229) ## Which issue does this PR close? - Part of apache#18160 ## Rationale for this change As we spend more effort optimizing the number of IO requests made during various scenarios, we need to ensure we have test coverage to: 1. Verify that the optimizations are working as intended 2. Prevent regressions in the future as code changes are made ## What changes are included in this PR? Add a new integration test that verifies what IO operations happen when creating and querying listing tables ## Are these changes tested? It is all tests ## Are there any user-facing changes? No, only tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As we spend more effort optimizing the number of IO requests made during various scenarios, we need to ensure we have test coverage to:
What changes are included in this PR?
Add a new integration test that verifies what IO operations happen when creating and querying listing tables
Are these changes tested?
It is all tests
Are there any user-facing changes?
No, only tests