Closed
Conversation
andygrove
reviewed
Aug 7, 2025
Comment on lines
+40
to
+42
| /// REGEXP_EXTRACT function extracts the first string in the str that match | ||
| /// the regexp expression and corresponding to the regex group index. | ||
| /// <https://spark.apache.org/docs/latest/api/sql/#regexp_extract> |
Member
There was a problem hiding this comment.
It may be worth adding documentation to explain that there are differences between Java's regex engine and Rust's regex engine, so users should not expect 100% compatibility
54 tasks
Contributor
|
Note that there was a previous PR for regexp_extract (#14282) - I don't know how it compares to this PR but just wanted to make it known. |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
People ask for regexp_extract in datafusion.
What changes are included in this PR?
This PR is fairly isolated and brings https://spark.apache.org/docs/latest/api/sql/#regexp_extract
from spark to datafusion-spark.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes, spark's regexp_extract() is now implemented.