feat(spark): implement spark datetime function date_add/date_sub#17024
Merged
alamb merged 3 commits intoapache:mainfrom Aug 11, 2025
Merged
feat(spark): implement spark datetime function date_add/date_sub#17024alamb merged 3 commits intoapache:mainfrom
alamb merged 3 commits intoapache:mainfrom
Conversation
Contributor
|
This CI failure is not related to the change, and it should be fixed now. I've triggered re-run for this CI job. |
andygrove
reviewed
Aug 7, 2025
| pub fn new() -> Self { | ||
| Self { | ||
| signature: Signature::exact( | ||
| vec![DataType::Date32, DataType::Int32], |
Member
There was a problem hiding this comment.
Spark accepts Int8, Int16, and Int32 for the second argument
override def inputTypes: Seq[AbstractDataType] =
Seq(DateType, TypeCollection(IntegerType, ShortType, ByteType))In the Comet implementation of date_add/date_sub, we support all three as well:
This was referenced Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914Rationale for this change
What changes are included in this PR?
implement spark function date_add/date_sub
Are these changes tested?
UT
Are there any user-facing changes?
No