Make AsyncScalarUDFImpl::invoke_async_with_args consistent with ScalarUDFImpl::invoke_with_args#16902
Merged
alamb merged 10 commits intoapache:mainfrom Aug 5, 2025
Merged
Conversation
github-actions
bot
added
logical-expr
geetanshjuneja
force-pushed
the
AsyncScalarUDFImpl
branch
from
738c72d to
522ea9a
Compare
xudong963
approved these changes
Jul 26, 2025
Member
xudong963
left a comment
xudong963
left a comment
There was a problem hiding this comment.
If there aren't any special backgrounds, this change lgtm
Contributor
|
Thank you @geetanshjuneja 🙏 This is technically an API change so should have a entry in the upgrade guide I think -- I'll push a commit to this PR to do so |
alamb
reviewed
Jul 29, 2025
| **Note:** DataFusion `50.0.0` has not been released yet. The information provided in this section pertains to features and changes that have already been merged to the main branch and are awaiting release in this version. | ||
| You can see the current [status of the `50.0.0 `release here](https://github.com/apache/datafusion/issues/16799) | ||
|
|
||
| ### `AsyncScalarUDFImpl::invoke_async_with_args` returns `ColumnarValue` |
Contributor
|
I plan to merge this Monday unless anyone would like additional time to comment |
Contributor
|
I merged up to resolve a conflict |
Contributor
|
I merged up to fix a merge conflict with this PR and plan to merge this PR when the CI passes |
Contributor
|
Thanks again @geetanshjuneja and @xudong963 |
hknlof
pushed a commit
to hknlof/datafusion
that referenced
this pull request
Aug 20, 2025
…alarUDFImpl::invoke_with_args` (apache#16902) * Change AsyncScalarUDFImpl::invoke_async_with_args return type to ColumnarValue * fix docs * cargo fmt * cargo clippy * Add a note in the upgrade guide * Fix merge blunder --------- Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
AsyncScalarUDFImpl::invoke_async_with_argsconsistent withScalarUDFImpl::invoke_with_args#16896.Rationale for this change
What changes are included in this PR?
Changed
AsyncScalarUDFImpl::invoke_async_with_argsreturn type toColumnarValue.Are these changes tested?
Are there any user-facing changes?