Repository navigation
Support utf8view for spark hex - #16885
Conversation
| DataType::Utf8View => { | ||
| let array = as_string_view_array(array)?; | ||
|
|
||
| let hexed: StringArray = array |
There was a problem hiding this comment.
Thanks @xudong963 , a minor question:
Here hexed is StringArray, why not using StringViewArray? Is it because we don't support it for the usage for this function?
It looks like the upper level spark don't support utf8view?
There was a problem hiding this comment.
I saw that the return type of the function is String https://docs.databricks.com/gcp/en/sql/language-manual/functions/hex#returns
There was a problem hiding this comment.
I saw that the return type of the function is String https://docs.databricks.com/gcp/en/sql/language-manual/functions/hex#returns
Ok so the upstream looks like we should return string.
|
thanks all |
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?