feat(spark): Implement Spark string function luhn_check#16848
Merged
comphead merged 5 commits intoapache:mainfrom Jul 25, 2025
Merged
feat(spark): Implement Spark string function luhn_check#16848comphead merged 5 commits intoapache:mainfrom
string function luhn_check#16848comphead merged 5 commits intoapache:mainfrom
Conversation
Standing-Man
changed the title
string function luhn_check
Standing-Man
commented
Jul 22, 2025
Signed-off-by: Alan Tang <[email protected]>
Signed-off-by: Alan Tang <[email protected]>
Standing-Man
commented
Jul 24, 2025
alamb
approved these changes
Jul 24, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Standing-Man -- this looks good to me
@shehabgamin does this look good to you (at a high level)?
Signed-off-by: Alan Tang <[email protected]>
Contributor
Will review when I'm home in the next few hours! |
comphead
approved these changes
Jul 25, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @Standing-Man it is LGTM
shehabgamin
reviewed
Jul 25, 2025
Contributor
shehabgamin
left a comment
shehabgamin
left a comment
There was a problem hiding this comment.
Well done! Just some minor things and then this looks good to me!
Signed-off-by: Alan Tang <[email protected]>
shehabgamin
approved these changes
Jul 25, 2025
Contributor
shehabgamin
left a comment
shehabgamin
left a comment
There was a problem hiding this comment.
My apologies I didn't notice this during my first review. We need 1 test for array input.
Approving the PR as this is simple to add.
Well done!
Signed-off-by: Alan Tang <[email protected]>
Contributor
Author
|
Appreciate the reviews, everyone! |
Contributor
|
Nice teamwork! Thanks everyone |
Contributor
|
✋ ✋ |
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
…6848) * feat(spark): Implement Spark luhn_check function Signed-off-by: Alan Tang <[email protected]> * test(spark): add more tests Signed-off-by: Alan Tang <[email protected]> * feat(spark): set the signature to be Utf8 type Signed-off-by: Alan Tang <[email protected]> * chore: add more types for luhn_check function Signed-off-by: Alan Tang <[email protected]> * test: add test for array input Signed-off-by: Alan Tang <[email protected]> --------- Signed-off-by: Alan Tang <[email protected]>
54 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914.stringfunctionluhn_check#16612 andluhn_checkfunction #16580.Rationale for this change
What changes are included in this PR?
Implement Spark
luhn_checkfunctionAre these changes tested?
Yes
Are there any user-facing changes?
Yes