Skip to content

Comments

Revert Finalize support for RightMark join + Mark join#16597

Merged
comphead merged 1 commit intoapache:mainfrom
comphead:dev
Jun 27, 2025
Merged

Revert Finalize support for RightMark join + Mark join#16597
comphead merged 1 commit intoapache:mainfrom
comphead:dev

Conversation

@comphead
Copy link
Contributor

@comphead comphead commented Jun 27, 2025 •
edited
Loading

…p (#16488)"

This reverts commit d73f0e8.

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) common Related to common crate physical-plan Changes to the physical-plan crate labels Jun 27, 2025
@comphead comphead mentioned this pull request Jun 27, 2025
Closed
@comphead comphead changed the title Revert "feat: Finalize support for RightMark join + Mark join swa… Revert Finalize support for RightMark join + Mark join Jun 27, 2025
@alamb
Copy link
Contributor

alamb commented Jun 27, 2025

FYI @jonathanc-n

alamb
alamb approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @comphead -- I think it is a good idea to back this out and fix it for real when we are ready

@comphead
Copy link
Contributor Author

comphead commented Jun 27, 2025

Thank you @comphead -- I think it is a good idea to back this out and fix it for real when we are ready

we should probably ask to run extended tests if PR label is one of core, physical-expr, logical-expr, optimizer

@alamb
Copy link
Contributor

alamb commented Jun 27, 2025

Thank you @comphead -- I think it is a good idea to back this out and fix it for real when we are ready

we should probably ask to run extended tests if PR label is one of core, physical-expr, logical-expr, optimizer

Yeah, I think we never figured out how to actually trigger it via comments (there is some vestigal github action but i don't htink it works reliably)

@comphead comphead merged commit 8d772e5 into apache:main Jun 27, 2025
29 of 30 checks passed
@jonathanc-n
Copy link
Contributor

jonathanc-n commented Jul 2, 2025

@alamb @comphead How do you run extended tests?

@comphead
Copy link
Contributor Author

comphead commented Jul 2, 2025

@alamb @comphead How do you run extended tests?

I'm not sure if you can access it https://github.com/apache/datafusion/actions/workflows/extended.yml

@alamb
Copy link
Contributor

alamb commented Jul 3, 2025 •
edited
Loading

I think you can just put a comment like this in your PR

Run extended tests

If not, you can also run it manually

https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#running-tests-sqlite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

common Related to common crate core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-plan Changes to the physical-plan crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extended tests are failing

3 participants

@comphead @alamb @jonathanc-n