doc: Add comments to clarify algorithm for MarkJoins#16436
Merged
alamb merged 4 commits intoapache:mainfrom Jun 19, 2025
Merged
doc: Add comments to clarify algorithm for MarkJoins#16436alamb merged 4 commits intoapache:mainfrom
MarkJoins#16436alamb merged 4 commits intoapache:mainfrom
Conversation
alamb
reviewed
Jun 18, 2025
alamb
approved these changes
Jun 19, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @jonathanc-n and @eejbyfeldt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The algorithm that is used for mark joins in
calculate_indices_by_join_typemight be confusing for newer contributors so we should add a comment to clarify.What changes are included in this PR?
Added comments with an example to explain how the algorithm works.