feat: Support serde for FileScanConfig batch_size#15335
Merged
alamb merged 1 commit intoapache:mainfrom Mar 21, 2025
Merged
Conversation
alamb
reviewed
Mar 20, 2025
Contributor
There was a problem hiding this comment.
Thank you @westhide
Should we remove the batch_size from JSON source too?
| reserved 10; | ||
|
|
||
| datafusion_common.Constraints constraints = 11; | ||
| optional uint32 batch_size = 12; |
Contributor
There was a problem hiding this comment.
perhaps we can use uint64 as batch_size is a usize 🤔
0959545 to
27676a0
Compare
Contributor
Author
Can we add pub trait FileSource: Send + Sync {
/// Creates a `dyn FileOpener` based on given parameters
fn create_file_opener(
&self,
object_store: Arc<dyn ObjectStore>,
base_config: &FileScanConfig,
partition: usize,
) -> Arc<dyn FileOpener>;
// ...
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Support serde for FileScanConfig
batch_sizedatafusion/datafusion/datasource/src/file_scan_config.rs
Lines 172 to 190 in 19dd46d
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?